Merge lp:~corey.bryant/charms/trusty/quantum-gateway/use-stable into lp:charms/trusty/quantum-gateway

Proposed by Corey Bryant
Status: Merged
Merged at revision: 74
Proposed branch: lp:~corey.bryant/charms/trusty/quantum-gateway/use-stable
Merge into: lp:charms/trusty/quantum-gateway
Diff against target: 12 lines (+1/-1)
1 file modified
tests/basic_deployment.py (+1/-1)
To merge this branch: bzr merge lp:~corey.bryant/charms/trusty/quantum-gateway/use-stable
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+239470@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #797 trusty-quantum-gateway for corey.bryant mp239470
    LINT OK: believed to pass, but you should confirm results

LINT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.797:
I: config.yaml: option ext-port has no default value
I: config.yaml: option os-data-network has no default value
I: config.yaml: option instance-mtu has no default value
I: config.yaml: option external-network-id has no default value

Full lint output: http://paste.ubuntu.com/8707138/
Build: http://10.98.191.181:8080/job/charm_lint_check/797/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #605 trusty-quantum-gateway for corey.bryant mp239470
    UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.605:
----------------------------------------------------------------------
Ran 82 tests in 3.640s

OK

Full unit output: http://paste.ubuntu.com/8707141/
Build: http://10.98.191.181:8080/job/charm_unit_test/605/

Revision history for this message
Liam Young (gnuoy) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/basic_deployment.py'
2--- tests/basic_deployment.py 2014-10-09 16:12:53 +0000
3+++ tests/basic_deployment.py 2014-10-23 20:14:04 +0000
4@@ -24,7 +24,7 @@
5 class QuantumGatewayBasicDeployment(OpenStackAmuletDeployment):
6 """Amulet tests on a basic quantum-gateway deployment."""
7
8- def __init__(self, series, openstack=None, source=None, stable=False):
9+ def __init__(self, series, openstack=None, source=None, stable=True):
10 """Deploy the entire test environment."""
11 super(QuantumGatewayBasicDeployment, self).__init__(series, openstack,
12 source, stable)

Subscribers

People subscribed via source and target branches