Merge lp:~corey.bryant/charms/trusty/keystone/use-stable into lp:~openstack-charmers-archive/charms/trusty/keystone/trunk

Proposed by Corey Bryant
Status: Merged
Merged at revision: 88
Proposed branch: lp:~corey.bryant/charms/trusty/keystone/use-stable
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
tests/basic_deployment.py (+1/-1)
To merge this branch: bzr merge lp:~corey.bryant/charms/trusty/keystone/use-stable
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+239473@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #800 trusty-keystone for corey.bryant mp239473
    LINT OK: believed to pass, but you should confirm results

LINT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.800:
I: config.yaml: option os-public-network has no default value
I: config.yaml: option os-admin-network has no default value
I: config.yaml: option ssl_cert has no default value
I: config.yaml: option os-internal-network has no default value

Full lint output: http://paste.ubuntu.com/8707153/
Build: http://10.98.191.181:8080/job/charm_lint_check/800/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #608 trusty-keystone for corey.bryant mp239473
    UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.608:
----------------------------------------------------------------------
Ran 37 tests in 3.193s

OK

Full unit output: http://paste.ubuntu.com/8707160/
Build: http://10.98.191.181:8080/job/charm_unit_test/608/

Revision history for this message
Liam Young (gnuoy) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/basic_deployment.py'
2--- tests/basic_deployment.py 2014-09-29 20:36:04 +0000
3+++ tests/basic_deployment.py 2014-10-23 20:15:08 +0000
4@@ -19,7 +19,7 @@
5 class KeystoneBasicDeployment(OpenStackAmuletDeployment):
6 """Amulet tests on a basic keystone deployment."""
7
8- def __init__(self, series=None, openstack=None, source=None, stable=False):
9+ def __init__(self, series=None, openstack=None, source=None, stable=True):
10 """Deploy the entire test environment."""
11 super(KeystoneBasicDeployment, self).__init__(series, openstack, source, stable)
12 self._add_services()

Subscribers

People subscribed via source and target branches