Merge lp:~corey.bryant/charms/trusty/glance/proxy-none into lp:~openstack-charmers-archive/charms/trusty/glance/next

Proposed by Corey Bryant
Status: Merged
Merged at revision: 121
Proposed branch: lp:~corey.bryant/charms/trusty/glance/proxy-none
Merge into: lp:~openstack-charmers-archive/charms/trusty/glance/next
Diff against target: 11 lines (+2/-0)
1 file modified
hooks/charmhelpers/contrib/python/packages.py (+2/-0)
To merge this branch: bzr merge lp:~corey.bryant/charms/trusty/glance/proxy-none
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+262889@code.launchpad.net

Description of the change

See the following charm-helpers mp for an explanation of this fix: https://code.launchpad.net/~corey.bryant/charm-helpers/proxy-none/+merge/262885

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5594 glance-next for corey.bryant mp262889
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5594/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #5226 glance-next for corey.bryant mp262889
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5226/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4762 glance-next for corey.bryant mp262889
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4762/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/charmhelpers/contrib/python/packages.py'
2--- hooks/charmhelpers/contrib/python/packages.py 2015-05-07 18:53:55 +0000
3+++ hooks/charmhelpers/contrib/python/packages.py 2015-06-24 19:16:16 +0000
4@@ -36,6 +36,8 @@
5 def parse_options(given, available):
6 """Given a set of options, check if available"""
7 for key, value in sorted(given.items()):
8+ if not value:
9+ continue
10 if key in available:
11 yield "--{0}={1}".format(key, value)
12

Subscribers

People subscribed via source and target branches