Merge lp:~corey.bryant/charm-helpers/install-warning into lp:charm-helpers

[Corey Bryant]

[Corey Bryant (corey.bryant)]

If an install_remote() handler fails, it should provide a clear error. For example, currently if git clone fails, the install_remote() code masks the original exception that was raised by the git handler, and raises UnhandledSource, making it difficult to understand what the cause of the original failure is.

This fix logs the original exception details as a warning before the UnhandledSource traceback.

=== modified file 'charmhelpers/fetch/__init__.py'
--- charmhelpers/fetch/__init__.py	2015-07-02 10:21:01 +0000
+++ charmhelpers/fetch/__init__.py	2015-07-09 19:56:43 +0000
@@ -378,8 +378,9 @@
     for handler in handlers:
         try:
             installed_to = handler.install(source, *args, **kwargs)
-        except UnhandledSource:
-            pass
+        except UnhandledSource as e:
+            log('Install source attempt unsuccessful: {}'.format(e),
+                level='WARNING')
     if not installed_to:
         raise UnhandledSource("No handler found for source {}".format(source))
     return installed_to

=== modified file 'charmhelpers/fetch/giturl.py'
--- charmhelpers/fetch/giturl.py	2015-05-27 12:55:44 +0000
+++ charmhelpers/fetch/giturl.py	2015-07-09 19:56:43 +0000
@@ -67,7 +67,7 @@
         try:
             self.clone(source, dest_dir, branch, depth)
         except GitCommandError as e:
-            raise UnhandledSource(e.message)
+            raise UnhandledSource(e)
         except OSError as e:
             raise UnhandledSource(e.strerror)
         return dest_dir