Merge lp:~corey.bryant/charm-helpers/depth-clone-only into lp:charm-helpers

[Corey Bryant]

[Corey Bryant (corey.bryant)]

While --depth is a valid option on 'git pull' it doesn't seem to work all that great. For example, --depth 0 is valid for 'git clone' but not for 'git pull'. I don't see any reason for it to be specified on 'git pull' so this patch only uses --depth with 'git clone'. As a historical point, 'git pull' was just recently added to this code while 'git clone' with --depth already existed prior to that.

[Liam Young (gnuoy)]

Approve

review: Approve

=== modified file 'charmhelpers/fetch/giturl.py'
--- charmhelpers/fetch/giturl.py	2016-01-08 13:27:39 +0000
+++ charmhelpers/fetch/giturl.py	2016-01-08 15:06:52 +0000
@@ -49,8 +49,8 @@
             cmd = ['git', '-C', dest, 'pull', source, branch]
         else:
             cmd = ['git', 'clone', source, dest, '--branch', branch]
-        if depth:
-            cmd.extend(['--depth', depth])
+            if depth:
+                cmd.extend(['--depth', depth])
         check_call(cmd)
 
     def install(self, source, branch="master", dest=None, depth=None):