Merge lp:~coolyashish/postorius/add_email_address_in_settings into lp:postorius

Proposed by Ashish
Status: Rejected
Rejected by: Terri
Proposed branch: lp:~coolyashish/postorius/add_email_address_in_settings
Merge into: lp:postorius
Diff against target: 10 lines (+1/-1)
1 file modified
src/postorius/models.py (+1/-1)
To merge this branch: bzr merge lp:~coolyashish/postorius/add_email_address_in_settings
Reviewer Review Type Date Requested Status
Terri Pending
Review via email: mp+252939@code.launchpad.net

Description of the change

Previously we are getting error on add email address page in user's settings as there is not email_confirmation_from set in the send_confirmation_link function in AddressConfirmationProfile model. This change adds the required email in the function.

To post a comment you must log in.
Revision history for this message
Abhilash Raj (raj-abhilash1) wrote :

We don't want to send confirmation email from the user's email, it should be from listowner or some other address (like noreply@domain or something).

Revision history for this message
Terri (terriko) wrote :

Unmerged revisions

206. By Ashish

EMAIL_CONFIRMATION_FROM in AddressConfirmationProfile.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/models.py'
2--- src/postorius/models.py 2015-02-09 14:35:44 +0000
3+++ src/postorius/models.py 2015-03-13 18:25:29 +0000
4@@ -291,5 +291,5 @@
5 settings, 'EMAIL_CONFIRMATION_SUBJECT', u'Confirmation needed')
6 send_mail(email_subject,
7 get_template(template_path).render(template_context),
8- getattr(settings, 'EMAIL_CONFIRMATION_FROM'),
9+ getattr(settings, 'EMAIL_CONFIRMATION_FROM', self.user.email),
10 [self.email])

Subscribers

People subscribed via source and target branches