lp:~connman-maintainers/connman/head

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Related snap packages

Related bugs

Related blueprints

8758. By Johannes Emerich <email address hidden> on 2025-08-04

service: Fix comparison of services of same preferred type

The service_compare_preferred() function is called twice in
service_compare(), once with a guard to only use it on services with
differing types, but once without any such guard. In the latter case,
when comparing two services of the same preferred technology, it always
returns -1 because it checks service_a first and exits immediately, when
one would normally expect that comparison to result in a tie (return
value 0).

This causes the parent service_compare() function to terminate its
comparison early instead of applying appropriate tie-breakers like
online status, Strength or Name. The result is an unstable sort order
that depends on the initial order of services.

This patch adds a condition to service_compare_preferred() so that
the preference logic is only applied to services of different types,
without relying on calling contexts to make such checks.

I ran into this issue when reading sources to understand how ConnMan
would sort two connected Ethernet services, when one is 'online' and one
is 'ready' and 'ethernet' is in the preferred technologies list. It
seems that their online state would in fact not matter at all, instead
the service that happened to appear first in the list would win.

The issue may have been introduced in [1] when
service_compare_preferred() was extracted from its original context in
which the comparison was only applied to services of unequal types.

[1]
31d9ce64a067 ("service: Let PreferredTechnologies overrule connected service sorting")

8757. By Grant on 2025-08-04

doc: Document the 'DefaultEnabledTechnologies' setting.

This documents the 'DefaultEnabledTechnologies' configuration setting.

8756. By Grant on 2025-08-04

technology: Leverage 'DefaultEnabledTechnologies' setting.

This leverages the new 'DefaultEnabledTechnologies' configuration
setting.

8755. By Grant on 2025-08-04

main: Introduce 'DefaultEnabledTechnologies' setting.

This introduces a new 'DefaultEnabledTechnologies' configuration
setting.

Since nearly the beginning of connman, it has behaved such that the
Ethernet technology is enabled (that is, powered) by
default. Currently, this is hard-coded behavior into
src/technology.c:technology_load.

However, if a different or additional technology is desired, there has
historically been no way to achieve this via configuration.

The 'DefaultEnabledTechnologies' key/value pair is a list of
technologies that are marked enabled (that is, powered) by default,
separated by commas ",". The default value for this entry when empty
is 'ethernet', matching the legacy behavior prior to the introduction
of this setting.

8754. By Jussi Laakkonen <email address hidden> on 2025-08-01

agent: Cancel agent request on NoReply D-Bus error

Handle also the NoReply D-Bus error as this is commonly sent back when
the timeout set for the request is exceeded. Canceling the request later
becomes impossible as agent->pending will be set to NULL in
agent_finalize_pending(). Thus, making later calls to
connman_agent_cancel() to not to close down agent dialogs but instead
they are piled up on top of each other.

8753. By Marcel Holtmann on 2025-07-24

Release 1.45

8752. By Jaeyoon Jung <email address hidden> on 2025-07-09

client: Add missing newlines on error messages

This adds missing newlines at the end of some error messages.

8751. By Andrea Ricchi <email address hidden> on 2025-06-05

timezone: Replace Localtime file copy with symbolic link

Based on the `man 5 localtime` documentation the `/etc/localtime`
file is expected to be a symbolic link, not a standalone
regular file.

This change replaces `write_file` with `write_symlink`, avoiding
unnecessary file I/O and memory mapping. It ensures Localtime accurately
reflects the selected timezone without duplicating data. This also
fixes `__connman_timezone_lookup()`, which requires Localtime to be a
symlink to function correctly.

8750. By Andrea Ricchi <email address hidden> on 2025-06-05

Revert "timezone: Fix compare_file comparison in timezone checking"

This reverts commit f20ccd19a62bd01aa117bfc8e7c388d2a16cde05.

`compare_file` is intended to work with symlinks, enabling
full and accurate matching between the requested timezone and the zoneinfo
database.

8749. By Michael Nazzareno Trimarchi on 2025-05-15

timezone: Fix compare_file comparison in timezone checking

The original condition incorrectly returned -1 when the real path and the
provided pathname matched, due to a flawed use of `g_strcmp0`. This patch
corrects the logic to return 0 (success) when the paths match, ensuring
proper file comparison behavior.