lp:~connman-maintainers/connman/head

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

8224. By Daniel Wagner on 2022-08-01

AUTHORS: Mention Nathan's contributions

8223. By Nathan Crandall <email address hidden> on 2022-08-01

gweb: Fix OOB write in received_data()

There is a mismatch of handling binary vs. C-string data with memchr
and strlen, resulting in pos, count, and bytes_read to become out of
sync and result in a heap overflow. Instead, do not treat the buffer
as an ASCII C-string. We calculate the count based on the return value
of memchr, instead of strlen.

Fixes: CVE-2022-32292

8222. By Daniel Wagner on 2022-08-01

wispr: Update portal context references

Maintain proper portal context references to avoid UAF.

Fixes: CVE-2022-32293

8221. By Daniel Wagner on 2022-08-01

wispr: Add reference counter to portal context

Track the connman_wispr_portal_context live time via a
refcounter. This only adds the infrastructure to do proper reference
counting.

Fixes: CVE-2022-32293

8220. By Daniel Wagner on 2022-08-01

wispr: Ignore NULL proxy

connmand[16822]: Failed to find URL:http://ipv6.connman.net/online/status.html
connmand[16822]: src/wispr.c:proxy_callback() proxy (null)
(connmand:16449): GLib-CRITICAL **: 10:15:43.812: g_str_has_prefix: assertion 'str != NULL' failed

8219. By Daniel Wagner on 2022-08-01

wispr: Rename wispr_portal_list to wispr_portal_hash

This data structure is a hash table, so replace the '_list' with
'_hash' to reduce the possibility for confusion.

Signed-off-by: Daniel Wagner <email address hidden>

8218. By Seung-Woo Kim <email address hidden> on 2022-05-25

wispr: Prevent use-after-free from __connman_wispr_stop()

From __connman_wispr_stop(), list element wispr_portal freed by
g_hash_table_remove() is accessed. Prevent the use-after-free by
accessing the list element before free.

8217. By Daniel Wagner on 2022-05-25

doc: Add note SingleConnectedTechnology can't be used with VPN

SingleConnectedTechnology can't be used with VPNs. VPNs rely on a
transport which is from a different technology group.

Reported by Thomas Bartosik.

8216. By Jakub Jirutka <email address hidden> on 2022-05-16

service: Add "Ethernet" property for VPN into n.c.Manager GetServices

Scope:
This patch affects the Service properties exposed by D-Bus method
GetServices in interface net.connman.Manager.

Before (current state):
Services of type WIFI, ETHERNET, BLUETOOTH, and GADGET have property
"Ethernet" with a dictionary of "Method", "Interface", "Address", and
"MTU". Services of type VPN (and also P2P, GPS, and SYSTEM) don't include
this property, althrough VPNs are IP-based too and the data is available
(at least for some, e.g. OpenVPN, not sure if all).

After (proposed change):
Even services of type VPN includes property "Ethernet".

Motivation:
ConnMan integration with resolvconf(8) via D-Bus
(https://github.com/jirutka/connman-resolvconf) - I need to know
"Interface" even for VPN services.

Considerations:
Function append_ethernet in src/service.c checks if either
service->ipconfig_ipv4 or service->ipconfig_ipv6 is non-NULL and do
nothing if this condition is not satisfied. Otherwise,
__connman_ipconfig_append_ethernet from src/ipconfig.c is called.
This function checks if the index of passed service->ipconfig_ipv4
(or _ipv6) is present in ipdevice_hash. If it's not, it just sets
"Method" property with value "auto" and returns.
Thus I think this change shouldn't break anything, even if ipconfig
data is not available for some VPN types. I tested it myself with just
OpenVPN provider though.

This may introduce an asymmetry between Service properties returned by
GetServices and signal PropertyChanged in interface net.connman.Service
- change in "Ethernet" is currently not being announced for VPN
services. I originally wanted to implement this as well (actually, before
GetServices), but got lost in code duplication and unclear relation
between src/ and vpn/.
Anyway, I don't think this asymetry is a problem (and probably more
asymetries already exist there?).

8215. By Ryan Smith <email address hidden> on 2022-05-16

clock: fix time update transition auto->manual

When the TimeUpdates property is changed via D-Bus from auto to manual,
the change is written out to the settings state file. However, it does
no modify the current service. This causes the service to continue to
synchronize time even after TimeUpdates being set to manual. This patch
updates the service whenever any change is made to the TimeUpdates setting.