Merge lp:~compiz-team/compiz/compiz.fix_1169170 into lp:compiz/0.9.10

Proposed by Sam Spilsbury
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3657
Merged at revision: 3658
Proposed branch: lp:~compiz-team/compiz/compiz.fix_1169170
Merge into: lp:compiz/0.9.10
Diff against target: 12 lines (+1/-1)
1 file modified
tests/xorg-gtest/src/compiz-xorg-gtest.cpp (+1/-1)
To merge this branch: bzr merge lp:~compiz-team/compiz/compiz.fix_1169170
Reviewer Review Type Date Requested Status
MC Return Approve
PS Jenkins bot (community) continuous-integration Approve
Compiz Maintainers Pending
Review via email: mp+159056@code.launchpad.net

Commit message

Don't timeout after 3000ms when asking compiz for a startup message.

It can sometimes take longer in the valgrind case. Also timeouts are
bad design for tests.

(LP: #1169170)

Description of the change

Don't timeout after 3000ms when asking compiz for a startup message.

It can sometimes take longer in the valgrind case. Also timeouts are
bad design for tests.

(LP: #1169170)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
MC Return (mc-return) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/xorg-gtest/src/compiz-xorg-gtest.cpp'
2--- tests/xorg-gtest/src/compiz-xorg-gtest.cpp 2013-03-29 18:41:26 +0000
3+++ tests/xorg-gtest/src/compiz-xorg-gtest.cpp 2013-04-16 00:58:33 +0000
4@@ -678,7 +678,7 @@
5 ct::CompizXorgSystemTest::StartCompiz (ct::CompizProcess::StartupFlags flags,
6 const ct::CompizProcess::PluginList &plugins)
7 {
8- priv->mProcess.reset (new ct::CompizProcess (Display (), flags, plugins, 3000));
9+ priv->mProcess.reset (new ct::CompizProcess (Display (), flags, plugins));
10 }
11
12 class ct::PrivateAutostartCompizXorgSystemTest

Subscribers

People subscribed via source and target branches

to all changes: