Merge lp:~compiz-team/compiz/compiz.fix_1127866 into lp:compiz/0.9.9

[Sam Spilsbury]

Workaround hangs in glXBindTexImageEXT - we need a server grab for the
external pixmap case, but we can just revert to using copytex if using
VirtualBox for now.

(LP: #1127866)

Workaround hangs in glXBindTexImageEXT - we need a server grab for the
external pixmap case, but we can just revert to using copytex if using
VirtualBox for now.

(LP: #1127866)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3609
http://jenkins.qa.ubuntu.com/job/compiz-ci/52/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/89/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-pbuilder/./build=pbuilder,distribution=raring,flavor=amd64/441/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/52//rebuild/?

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

That's ok for now, let's wait the proper patch to go in upstream before reverting this.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2013-02-08 04:01:48 +0000
+++ debian/changelog	2013-02-17 07:32:24 +0000
@@ -1,3 +1,13 @@
+compiz (1:0.9.9~daily13.02.08-0ubuntu2) UNRELEASED; urgency=low
+
+  * debian/patches/100_workaround_virtualbox_hang.patch
+    - VirtualBox uses a shared-memory texture_from_pixmap_implementation
+    which is not compatible with our server grab usage, so force
+    a different bind method when running with virtualbox and binding
+    an externally managed texture
+
+ -- Sam Spilsbury <[e-mail]>  Sun, 17 Feb 2013 10:26:40 +0800
+
 compiz (1:0.9.9~daily13.02.08-0ubuntu1) raring; urgency=low
 
   [ MC Return ]

=== modified file 'debian/compiz-plugins-default.install'
--- debian/compiz-plugins-default.install	2012-06-19 11:22:48 +0000
+++ debian/compiz-plugins-default.install	2013-02-17 07:32:24 +0000
@@ -1,6 +1,7 @@
 debian/tmp/usr/*/compiz/*animation.*
 debian/tmp/usr/*/compiz/*compiztoolbox.*
 debian/tmp/usr/*/compiz/*composite.*
+debian/tmp/usr/*/compiz/*copytex.*
 debian/tmp/usr/*/compiz/*decor.*
 debian/tmp/usr/*/compiz/*expo.*
 debian/tmp/usr/*/compiz/*ezoom.*

=== modified file 'debian/compiz-plugins.install'
--- debian/compiz-plugins.install	2013-02-05 12:51:42 +0000
+++ debian/compiz-plugins.install	2013-02-17 07:32:24 +0000
@@ -3,7 +3,6 @@
 debian/tmp/usr/*/compiz/*bench.*
 debian/tmp/usr/*/compiz/*clone.*
 debian/tmp/usr/*/compiz/*commands.*
-debian/tmp/usr/*/compiz/*copytex.*
 debian/tmp/usr/*/compiz/*crashhandler.*
 debian/tmp/usr/*/compiz/*cube.*
 debian/tmp/usr/*/compiz/*cubeaddon.*

=== added file 'debian/patches/100_workaround_virtualbox_hang.patch'
--- debian/patches/100_workaround_virtualbox_hang.patch	1970-01-01 00:00:00 +0000
+++ debian/patches/100_workaround_virtualbox_hang.patch	2013-02-17 07:32:24 +0000
@@ -0,0 +1,176 @@
+Index: compiz/plugins/opengl/include/opengl/opengl.h
+===================================================================
+--- compiz.orig/plugins/opengl/include/opengl/opengl.h	2013-02-17 10:22:08.012876000 +0800
++++ compiz/plugins/opengl/include/opengl/opengl.h	2013-02-17 10:23:36.643958000 +0800
+@@ -578,6 +578,17 @@
+ 
+ extern GLScreenPaintAttrib defaultScreenPaintAttrib;
+ 
++namespace compiz
++{
++namespace opengl
++{
++namespace internal
++{
++class DriverWorkaroundQuery;
++}
++}
++}
++
+ class GLScreen;
+ class GLFramebufferObject;
+ class GLScreenInterface;
+@@ -770,6 +781,13 @@
+ 
+ 	bool glInitContext (XVisualInfo *);
+ 
++	/**
++	 * This is only meant to be used internally, here to avoid unnecessarily
++	 * breaking the API and ABI. Fetch any driver workarounds in place
++	 */
++	const compiz::opengl::internal::DriverWorkaroundQuery &
++	fetchDriverWorkarounds ();
++
+ 	WRAPABLE_HND (0, GLScreenInterface, bool, glPaintOutput,
+ 		      const GLScreenPaintAttrib &, const GLMatrix &,
+ 		      const CompRegion &, CompOutput *, unsigned int);
+Index: compiz/plugins/opengl/src/privates.h
+===================================================================
+--- compiz.orig/plugins/opengl/src/privates.h	2013-02-17 10:22:08.012876000 +0800
++++ compiz/plugins/opengl/src/privates.h	2013-02-17 10:23:36.643958000 +0800
+@@ -46,6 +46,24 @@
+ 
+ extern CompOutput *targetOutput;
+ 
++namespace compiz
++{
++namespace opengl
++{
++namespace internal
++{
++class DriverWorkaroundQuery
++{
++    public:
++
++	virtual ~DriverWorkaroundQuery () {};
++
++	virtual bool unsafeForExternalBinds () const = 0;
++};
++}
++}
++}
++
+ class GLDoubleBuffer :
+     public compiz::opengl::DoubleBuffer
+ {
+@@ -122,6 +140,7 @@
+ class PrivateGLScreen :
+     public ScreenInterface,
+     public compiz::composite::PaintHandler,
++    public compiz::opengl::internal::DriverWorkaroundQuery,
+     public OpenglOptions
+ {
+     public:
+@@ -206,6 +225,7 @@
+ 	std::vector<GLTexture::BindPixmapProc> bindPixmap;
+ 	bool hasCompositing;
+ 	bool commonFrontbuffer;
++	bool sharedMemoryTFP;
+ 	bool incorrectRefreshRate; // hack for NVIDIA specifying an incorrect
+ 				   // refresh rate, causing us to miss vblanks
+ 
+@@ -225,6 +245,10 @@
+ 
+ 	mutable CompString prevRegex;
+ 	mutable bool       prevBlacklisted;
++
++    private:
++
++	bool unsafeForExternalBinds () const;
+ };
+ 
+ class PrivateGLWindow :
+Index: compiz/plugins/opengl/src/screen.cpp
+===================================================================
+--- compiz.orig/plugins/opengl/src/screen.cpp	2013-02-17 10:22:08.012876000 +0800
++++ compiz/plugins/opengl/src/screen.cpp	2013-02-17 10:23:36.643958000 +0800
+@@ -67,6 +67,7 @@
+ 
+ 
+ using namespace compiz::opengl;
++namespace cglint = compiz::opengl::internal;
+ 
+ namespace GL {
+     #ifdef USE_GLES
+@@ -359,6 +360,18 @@
+ #endif
+ 
+ bool
++PrivateGLScreen::unsafeForExternalBinds () const
++{
++    return sharedMemoryTFP;
++}
++
++const cglint::DriverWorkaroundQuery &
++GLScreen::fetchDriverWorkarounds ()
++{
++    return *priv;
++}
++
++bool
+ GLScreen::glInitContext (XVisualInfo *visinfo)
+ {
+ #ifndef USE_GLES
+@@ -660,6 +673,7 @@
+ 
+     priv->commonFrontbuffer = true;
+     priv->incorrectRefreshRate = false;
++    priv->sharedMemoryTFP = false;
+     if (glRenderer != NULL && strstr (glRenderer, "on llvmpipe"))
+     {
+ 	/*
+@@ -680,6 +694,18 @@
+ 	priv->incorrectRefreshRate = true;
+     }
+ 
++    if (glVendor != NULL && strstr (glVendor, "Humper"))
++    {
++	/*
++	 * VirtualBox uses XShm/XCopyArea in order to implement
++	 * texture_from_pixmap. Because of this, they require
++	 * a second X connection to track damage events and
++	 * changes to the pixmap, and this is incompatible with
++	 * taking a server grab on when querying and binding
++	 * externally managed pixmaps */
++	priv->sharedMemoryTFP = true;
++    }
++
+     if (strstr (glExtensions, "GL_ARB_texture_non_power_of_two"))
+ 	GL::textureNonPowerOfTwo = true;
+     GL::textureNonPowerOfTwoMipmap = GL::textureNonPowerOfTwo;
+Index: compiz/plugins/opengl/src/texture.cpp
+===================================================================
+--- compiz.orig/plugins/opengl/src/texture.cpp	2013-02-17 10:22:08.012876000 +0800
++++ compiz/plugins/opengl/src/texture.cpp	2013-02-17 10:23:36.643958000 +0800
+@@ -41,6 +41,7 @@
+ #include "glx-tfp-bind.h"
+ 
+ namespace cgl = compiz::opengl;
++namespace cglint = compiz::opengl::internal;
+ 
+ #ifdef USE_GLES
+ std::map<Damage, EglTexture*> boundPixmapTex;
+@@ -648,6 +649,13 @@
+         !GL::textureFromPixmap)
+ 	return GLTexture::List ();
+ 
++    GLScreen *gs = GLScreen::get (screen);
++    const cglint::DriverWorkaroundQuery &query (gs->fetchDriverWorkarounds ());
++
++    if (query.unsafeForExternalBinds () &&
++	source == cgl::ExternallyManaged)
++	return GLTexture::List ();
++
+     GLTexture::List   rv (1);
+     TfpTexture        *tex = NULL;
+     unsigned int      target = 0;

=== modified file 'debian/patches/series'
--- debian/patches/series	2012-12-10 03:28:47 +0000
+++ debian/patches/series	2013-02-17 07:32:24 +0000
@@ -5,3 +5,4 @@
 ccsm_disable_unity_checkbox.patch
 99_valid_ccsm_desktop_file.patch
 unity_support_test.patch
+100_workaround_virtualbox_hang.patch

=== added file 'debian/profile_upgrades/com.canonical.unity.unity.03.upgrade'
--- debian/profile_upgrades/com.canonical.unity.unity.03.upgrade	1970-01-01 00:00:00 +0000
+++ debian/profile_upgrades/com.canonical.unity.unity.03.upgrade	2013-02-17 07:32:24 +0000
@@ -0,0 +1,2 @@
+[core]
++s0_active_plugins = copytex

=== modified file 'plugins/opengl/DRIVERS'
--- plugins/opengl/DRIVERS	2012-09-25 07:26:36 +0000
+++ plugins/opengl/DRIVERS	2013-02-17 07:32:24 +0000
@@ -53,12 +53,24 @@
  RESOLVED. WORKAROUND: detect when llvmpipe is active and force the usage
  of glXSwapBuffers on every frame
 
+ 2. llvmpipe will crash when a pixmap does not exist on the server
+ side and glXBindTexImageEXT is used on it.
+
+ RESOLVED. WORKAROUND: grab the server, query the server as to
+ whether or not the pixmap exists, call glXBindTexImageEXT and
+ then release the server grab. This will ensure we never call
+ glXBindTexImageEXT on a destroyed pixmap.
+
 virtualbox
 ==========
 
- 1. vboxdrv may open a new X Server connection on the first call to
-    glXBindTexImageEXT. If compiz has a server grab during this time
-    (see the GLX_EXT_texture_from_pixmap spec s. 5) then compiz
-    will deadlock
+ 1. vboxdrv requires the usage of a second X Server connection
+    inside of glXBindTexImageEXT. If compiz requires a server
+    grab at this time (eg, the pixmap may not have its lifetime
+    managed by us, see issue #2 in llvmpipe), then the driver
+    will hang in glXBindTexImageEXT as it must use this connection
+    in order to listen for any new damage events.
 
- RESOLVED. WORKAROUND: don't implement this part of the spec for now
+ RESOLVED. WORKAROUND: force the usage of the copy-to-texture path
+ when using this driver ("Chromium") and binding an externally
+ managed pixmap to a texture