Merge lp:~compiz-team/compiz/compiz.fix_1110138 into lp:compiz/0.9.9

Proposed by Sam Spilsbury
Status: Merged
Approved by: Andrea Azzarone
Approved revision: 3555
Merged at revision: 3616
Proposed branch: lp:~compiz-team/compiz/compiz.fix_1110138
Merge into: lp:compiz/0.9.9
Diff against target: 19 lines (+8/-1)
1 file modified
plugins/decor/src/decor.cpp (+8/-1)
To merge this branch: bzr merge lp:~compiz-team/compiz/compiz.fix_1110138
Reviewer Review Type Date Requested Status
Andrea Azzarone Approve
PS Jenkins bot (community) continuous-integration Approve
MC Return Approve
Review via email: mp+147548@code.launchpad.net

Commit message

Make sure to update the frame extents when clients ask us to (LP: #1110138)

Description of the change

Make sure to update the frame extents when clients ask us to (LP: #1110138)

Unfortunately I can't get this under test in a way that doesn't involve invasive code changes. I don't have time to do those right now.

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :

LGTM. +1.
Have compiled and tested this with Emerald, but not with Java apps.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/decor/src/decor.cpp'
2--- plugins/decor/src/decor.cpp 2013-02-03 18:19:21 +0000
3+++ plugins/decor/src/decor.cpp 2013-02-10 08:47:22 +0000
4@@ -2367,7 +2367,14 @@
5 {
6 w = screen->findWindow (event->xclient.window);
7 if (w)
8- DecorWindow::get (w)->update (true);
9+ {
10+ DecorWindow *dw = DecorWindow::get (w);
11+
12+ /* Set the frameExtentsRequested flag so that we know to
13+ * at least update _NET_WM_FRAME_EXTENTS (LP: #1110138) */
14+ dw->frameExtentsRequested = true;
15+ dw->update (true);
16+ }
17 }
18 /* A decoration is pending creation, allow it to be created */
19 if (event->xclient.message_type == decorPendingAtom)

Subscribers

People subscribed via source and target branches