lp:~compiz-team/compiz/compiz.fix_1100564

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3572

Daniel van Vugt: Approve on 2013-01-22

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2013-01-19

Diff: 115 lines (+56/-11)

2 files modified

compizconfig/integration/gnome/src/ccs_gnome_integration.c (+33/-9)
compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp (+23/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1100564: Several memory leaks in strdup() from ccsGSettingsIntegratedSettingReadValue() from ccsGNOMEIntegrationBackendReadISAndSetSettingForType() from ccsGNOMEIntegrationBackendReadOptionIntoSetting()

High

Fix Released

Link a bug report

Related blueprints

3567. By Sam Spilsbury on 2013-01-18

We need to handle the default string type storage for the special
run_command_* keys as well, since they don't use the standard storage

3566. By Sam Spilsbury on 2013-01-17

Free the string before converting to a key.

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated
[ RUN ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption
[ OK ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption (497 ms)
[----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated (508 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (545 ms total)
[ PASSED ] 1 test.
==28512==
==28512== HEAP SUMMARY:
==28512== in use at exit: 0 bytes in 0 blocks
==28512== total heap usage: 1,200 allocs, 1,200 frees, 144,800 bytes allocated
==28512==
==28512== All heap blocks were freed -- no leaks are possible
==28512==
==28512== For counts of detected and suppressed errors, rerun with: -v
==28512== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)

3565. By Sam Spilsbury on 2013-01-17

Demonstrate the current behaviour of ccsIntegrationReadOptionIntoSetting with key values leaks:

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated
[ RUN ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption
[ OK ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption (497 ms)
[----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated (509 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (552 ms total)
[ PASSED ] 1 test.
==28295==
==28295== HEAP SUMMARY:
==28295== in use at exit: 11 bytes in 1 blocks
==28295== total heap usage: 1,200 allocs, 1,199 frees, 144,800 bytes allocated
==28295==
==28295== 11 bytes in 1 blocks are definitely lost in loss record 1 of 1
==28295== at 0x4C2CD7B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==28295== by 0x5D31961: strdup (strdup.c:42)
==28295== by 0x4EC353: CCSGNOMEIntegrationTestReadIntegrated_TestReadInKeyOption_Test::TestBody() (compizconfig_test_ccs_gnome_integration.cpp:347)
==28295== by 0x51EC59: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2090)
==28295== by 0x513A68: testing::Test::Run() (gtest.cc:2162)
==28295== by 0x513B46: testing::TestInfo::Run() (gtest.cc:2338)
==28295== by 0x513C84: testing::TestCase::Run() (gtest.cc:2445)
==28295== by 0x513F0C: testing::internal::UnitTestImpl::RunAllTests() (gtest.cc:4243)
==28295== by 0x51E7D9: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (gtest.cc:2090)
==28295== by 0x5132C0: testing::UnitTest::Run() (gtest.cc:3880)
==28295== by 0x4E8768: main (gtest_main.cc:38)
==28295==
==28295== LEAK SUMMARY:
==28295== definitely lost: 11 bytes in 1 blocks
==28295== indirectly lost: 0 bytes in 0 blocks
==28295== possibly lost: 0 bytes in 0 blocks
==28295== still reachable: 0 bytes in 0 blocks
==28295== suppressed: 0 bytes in 0 blocks

3564. By MC Return on 2013-01-16

Workspacenames plugin:
Workspace Naming requires the text plugin to work.

(LP: #1100172). Fixes: https://bugs.launchpad.net/bugs/1100172.

Approved by Daniel van Vugt, Sam Spilsbury.

3563. By PS Jenkins bot on 2013-01-16

Releasing 1:0.9.9~daily13.01.14-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

3562. By Didier Roche-Tolomelli on 2013-01-15

Set one workspace by default (LP: #868423). Fixes: https://bugs.launchpad.net/bugs/868423.

Approved by Daniel van Vugt, PS Jenkins bot.

3561. By Sami Jaktholm on 2013-01-12

Animation: Correctly specify the events an effect can be used with.

If AnimEffectUsedFor::none() is called, the effect will be marked to
be used with ALL events instead of NONE. This causes crashes if the
chosen random effect is not compatible with the triggering event.

For example dodge effect as random minimize animation causes segfault
as it's only supposed to be a focus in/out animation. Fixes: https://bugs.launchpad.net/bugs/1048840, https://bugs.launchpad.net/bugs/1098185.

Approved by Brandon Schaefer, Sam Spilsbury.

3560. By MC Return on 2013-01-12

Thumbnail:
Also damage the thumb if full opacity has been reached to fix the flickering of background and text.

(LP: #1098758). Fixes: https://bugs.launchpad.net/bugs/1098758.

Approved by Brandon Schaefer.

3559. By MC Return on 2013-01-12

td plugin:
Initialize class member variable bool mFtb in TdWindow::TdWindow (CompWindow *window) constructor.

Approved by Brandon Schaefer.

3558. By Sam Spilsbury on 2013-01-11

Call ccsIntegratedSettingListFree before returning the first value from ccsGNOMEIntegrationBackendGetIntegratedSetting

(LP: #1097661). Fixes: https://bugs.launchpad.net/bugs/1097661.

Approved by Daniel van Vugt.