Merge lp:~compiz-team/compiz/compiz.fix_1065687 into lp:compiz/0.9.9

Proposed by Sam Spilsbury
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3495
Merged at revision: 3495
Proposed branch: lp:~compiz-team/compiz/compiz.fix_1065687
Merge into: lp:compiz/0.9.9
Diff against target: 12 lines (+1/-1)
1 file modified
compizconfig/libcompizconfig/src/main.c (+1/-1)
To merge this branch: bzr merge lp:~compiz-team/compiz/compiz.fix_1065687
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+137436@code.launchpad.net

Commit message

Use abort () instead of assert (0); The latter doesn't seem to work
sometimes, and really, we want to abort (), the test assumes it.

(LP: #1085687)

Description of the change

Use abort () instead of assert (0); The latter doesn't seem to work
sometimes, and really, we want to abort (), the test assumes it.

(LP: #1085687)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Well assert() is only temporary. It gets converted to an empty expression ifdef NDEBUG. That might be the problem in some release build environment.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/libcompizconfig/src/main.c'
2--- compizconfig/libcompizconfig/src/main.c 2012-11-27 06:12:15 +0000
3+++ compizconfig/libcompizconfig/src/main.c 2012-12-02 18:39:21 +0000
4@@ -187,7 +187,7 @@
5 "This is either a programmer error or more than one static library \n"
6 "defining this interface has been linked in\n"
7 "Unable to continue, please file a bug about this\n", interface_type, object);
8- assert (0);
9+ abort ();
10
11 return NULL;
12 }

Subscribers

People subscribed via source and target branches