Code review comment for lp:~compiz-team/compiz/compiz.fix_1064791

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> Certainly if the type, or any identifier at all, is local to one file then you
> don't need to over-prefix it like a namespace. The identifier only needs to be
> unique within the file. Yes, "Integration" is a redundant word. And while
> "Wrapper", "Factory" and "Private" may be accurate you should re-evaluate if
> you need to have things wrapped, from factories or pimpl'd at all.

Wrappers - required for testing purposes
Private - that's fundamentally how libcompizconfig's object system works
Factory - need to delay instance creation until later, need to change the way instance creation works (we can't ever create a wrapper around a real GSettings object in testing)

>
> 32 characters is too long already. I'm sure you can find some literature about
> how human beings read text. You will find that we recognise words as symbols
> and do not look at the individual letters. However this readability breaks
> down at some length (which IMHO is shorter than 32).

To be fair, type names don't come up all that much - long names is more of a problem for variables than it is types, because types need to be searchable and not recognizable.

« Back to merge proposal