I am concerned about very long identifiers...
typedef struct _CCSGNOMEIntegrationGSettingsWrapperFactoryPrivate CCSGNOMEIntegrationGSettingsWrapperFactoryPrivate;
I cannot read that. The words are too long for my feeble human brain to recognize symbolically. And I'm sure most humans would agree. It is however very important for code to be readable by human beings for the sake of maintenance.
I know there's a lot of existing code written that way already. However it was landed without review due to limited time before release. So I'd like to say: No more new code with unreadably long identifiers please.
AFAIK, C/C++ should only accept up to 32 characters. And I've never seen anything even that long before now.
Secondly, "Bug #1064791: Redundant writes to plugins-with-set-keys" suggests a very simple problem that should have a very simple solution. So why "1663 lines (+1030/-243) 21 files modified" ?
I am concerned about very long identifiers... ationGSettingsW rapperFactoryPr ivate CCSGNOMEIntegra tionGSettingsWr apperFactoryPri vate;
typedef struct _CCSGNOMEIntegr
I cannot read that. The words are too long for my feeble human brain to recognize symbolically. And I'm sure most humans would agree. It is however very important for code to be readable by human beings for the sake of maintenance.
I know there's a lot of existing code written that way already. However it was landed without review due to limited time before release. So I'd like to say: No more new code with unreadably long identifiers please.
AFAIK, C/C++ should only accept up to 32 characters. And I've never seen anything even that long before now.
Secondly, "Bug #1064791: Redundant writes to plugins- with-set- keys" suggests a very simple problem that should have a very simple solution. So why "1663 lines (+1030/-243) 21 files modified" ?