lp:~compiz-team/compiz/compiz.fix_1063617.4

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9

Daniel van Vugt: Approve on 2012-11-27

PS Jenkins bot (community): Approve (continuous-integration) on 2012-11-26

Diff: 402 lines (+370/-1)

2 files modified

compizconfig/libcompizconfig/tests/CMakeLists.txt (+2/-1)
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_setting.cpp (+368/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1063617: 1:0.9.8+bzr3319-0ubuntu1 regression: keeps setting gsettings keys to wrong values

High

Fix Released

Link a bug report

Related blueprints

3483. By Sam Spilsbury on 2012-11-26

Remove unused func for now

3482. By Sam Spilsbury on 2012-11-24

Factor out some template bloat in ListValueContainer into non-templated
ListValueContainerBase.

Eliminate more template bloat in RawValueToListValue and
ContainedValueGenerator::InitializedSpawnedValue

Split NormalValueContainer into NormalValueContainerBase and
NormalValueContainer

3481. By Sam Spilsbury on 2012-11-24

Provide infrastructure for testing value containers.

It will be useful for later tests to be able to specify a value and allow
the use of templates to automatically create a CCSValue for those. These value
containers handle the tricky issues around how those values have their
lifecycles managed, as every value needs a valid parent setting in order
to be destroyed properly (as type information is stored in the parent
setting).

ContainNormal and ContainList are convenience functions which forward
to NormalValueContainer and ListValueContainer.

NormalValueContainer will wrap a normal "raw" value and provide a means to
construct a CCSValue on-demand and a way to get the raw value.

ListValueContainer will wrap a normal "raw" value as the first member of
a CCSSettingValueList, safely wrap that in a SettingValueListWrapper and
then provde a means to construct a CCSValue from that on-demand and a way
to get the raw CCSSettingValueList.

Both use RawValueCopy in order to handle internal value copy semantics
properly.

RawValueCopy returns a copy of the "raw" value (i.e. not another
CCSSettingValue), doing deep copies as appropriate. It is implemented
as a series of template specializations to handle some of the various
pointer types, such as const char * and CCSSettingValueList.

3480. By Sam Spilsbury on 2012-11-23

Fix typo in compiz_discover_tests COVERAGE target for
compizconfig_test_ccs_gnome_gsettings_integrated_setting

(LP: #1070411). Fixes: https://bugs.launchpad.net/bugs/1070411.

Approved by Daniel van Vugt.

3479. By Daniel van Vugt on 2012-11-22

Move opacity/brightness/saturation setting from glDraw into glDrawTexture
where it won't care about the plugin load order relative to decor any more.
This ensures the obs setting will always apply to the whole window including
decorations (LP: #1028809). Fixes: https://bugs.launchpad.net/bugs/1028809.

Approved by PS Jenkins bot, Sam Spilsbury.

3478. By Daniel van Vugt on 2012-11-22

Disable shadows for maximized windows. They only create annoyance and
confusion on adjacent monitors/workspaces. (LP: #928807). Fixes: https://bugs.launchpad.net/bugs/928807.

Approved by Sam Spilsbury, PS Jenkins bot.

3477. By Sam Spilsbury on 2012-11-21

Fix various test failures caused by not controlling the environment variable
COMPIZ_CONFIG_PROFILE. (LP: #1070817) (LP: #1077787). Fixes: https://bugs.launchpad.net/bugs/1070817, https://bugs.launchpad.net/bugs/1077787.

Approved by Daniel van Vugt, PS Jenkins bot.

3476. By Daniel van Vugt on 2012-11-19

Fix segfaults in test cases (LP: #1080555)
. Fixes: https://bugs.launchpad.net/bugs/1080555.

Approved by PS Jenkins bot.

3475. By Sami Jaktholm on 2012-11-19

Grid: Set GridWindow->lastTarget to GridMaximize only if the window
was fully maximized.

Currently the lastTarget is changed to GridMaximize also when the
window is only semi-maximized. So if you then try to maximize the
window with grid, grid thinks the target has not changed and overlay
is not shown.

Fixes LP: #1071689. Fixes: https://bugs.launchpad.net/bugs/1071689.

Approved by Daniel van Vugt, MC Return.

3474. By MC Return on 2012-11-19

Removed redundant assignment of 'currentProfilePath' to itself.

Approved by Daniel van Vugt, Sam Spilsbury.