lp:~compiz-team/compiz/compiz.fix_1052838

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.8 at revision 3379

Daniel van Vugt: Approve on 2012-09-19

jenkins (community): Approve (continuous-integration) on 2012-09-19

Diff: 98 lines (+36/-38)

1 file modified

plugins/opengl/src/texture.cpp (+36/-38)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1052838: compiz.fix_927168 broke ARM building

Critical

Fix Released

Link a bug report

Related blueprints

3379. By Sam Spilsbury on 2012-09-19

Fix FTBFS with BUILD_GLES

3378. By Sam Spilsbury on 2012-09-19

Check the pending frame of the window when looking to see if it is a "toplevel" window. There was a case where calling updateAttributes on a just-reparented window which hadn't yet got the ReparentNotify event for its frame window would cause subsequent calls to reconfigureXWindow which want to restack relative to it to fail because that frame window wasn't marked as "existing" yet, so we would detect that case as restacking relative to an invalid window and prevent the restack request.. Fixes: https://bugs.launchpad.net/bugs/1052773. Approved by Daniel van Vugt, Brandon Schaefer, jenkins.

3377. By Daniel van Vugt on 2012-09-18

Fix flickering and performance problems with using Unredirect Fullscreen
Windows with multiple monitors.
(LP: #1050749) (LP: #1051885)

Written by smspillaz. Simplified by vanvugt.. Fixes: https://bugs.launchpad.net/bugs/1050749, https://bugs.launchpad.net/bugs/1051885. Approved by Sam Spilsbury, Daniel van Vugt.

3376. By Sam Spilsbury on 2012-09-18

Check that pixmaps which aren't managed by us actually exist before binding.

It was possible for there to be a race condition for a pixmap to become
invalid on the server side if the client which did have control over thier
lifecycle freed them before we were done with them or disconnected. Drivers
have normally handled this condition by reading the contents of the undefined
memory directly without an error, however drivers such as LLVMpipe will
effectively dereference an invalid pointer and crash when you do this.

LP: #927168:
compiz crashed with SIGSEGV in
memmove() from
drisw_update_tex_buffer() from
dri_set_tex_buffer2() from
drisw_bind_tex_image() from
__glXBindTexImageEXT() from
TfpTexture::enable()

Most of the time we don't need to employ this check. Its only when we know
that we don't control the lifecycle of a pixmap that race conditions
such as these can occur.. Fixes: https://bugs.launchpad.net/bugs/927168. Approved by Daniel van Vugt, jenkins.

3375. By Iven Hsu on 2012-09-15

Fix (LP: #1050752). https://bugs.launchpad.net/compiz/+bug/1050752

In the initializing of the plugin, it should not only start handling the events, but also enable GL paint.. Fixes: https://bugs.launchpad.net/bugs/1050752. Approved by Sam Spilsbury.

3374. By Daniel van Vugt on 2012-09-14

Avoid a NULL dereference and give a useful error message instead.
(LP: #944653). Fixes: https://bugs.launchpad.net/bugs/944653. Approved by Sam Spilsbury, jenkins.

3373. By Łukasz Zemczak on 2012-09-13

It seems that with USE_GCONF disabled, the gsettings xslt files are not installed. I *think* this might help?. Fixes: . Approved by Brandon Schaefer, jenkins.

3372. By Daniel van Vugt on 2012-09-13

Ensure window decorations always get rendered after the window, not before.
This is how it was in compiz 0.9.7, and is required in order to resolve
unity panel shadow bug 1045705.. Fixes: . Approved by jenkins, Sam Spilsbury.

3371. By MC Return on 2012-09-13

Changed the default placement of the benchmark window from 0,0 to 100,50.
This avoids damaging the Unity shell, and hence avoids slowing down everything
when benchmark is visible. (LP: #1039406). Fixes: https://bugs.launchpad.net/bugs/1039406. Approved by Daniel van Vugt.

3370. By Daniel van Vugt on 2012-09-13

Workaround SubBuffer performance regression (LP: #1037411), which is actually
Mesa bug #54763.. Fixes: https://bugs.launchpad.net/bugs/1037411. Approved by jenkins.