Merge lp:~compiz-team/compiz/compiz.fix_1004848 into lp:compiz/0.9.8

Proposed by Sam Spilsbury on 2012-05-26
Status: Merged
Merged at revision: 3233
Proposed branch: lp:~compiz-team/compiz/compiz.fix_1004848
Merge into: lp:compiz/0.9.8
Diff against target: 11 lines (+0/-1)
1 file modified
compizconfig/compizconfig-python/tests/ (+0/-1)
To merge this branch: bzr merge lp:~compiz-team/compiz/compiz.fix_1004848
Reviewer Review Type Date Requested Status
Daniel van Vugt 2012-05-26 Approve on 2012-05-28
Compiz Maintainers 2012-05-28 Pending
Review via email:

Description of the change

  Don't read plugin.Initialized and test the value.

  The python bindings indicate that all this does is return whether or not
  the plugin is loaded, which is user-configurable and not deterministic.

      property Initialized:
          def __get__ (self):
              return bool (self.loaded)

  As such, we shouldn't be testing that value

To post a comment you must log in.
Daniel van Vugt (vanvugt) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/compizconfig-python/tests/'
2--- compizconfig/compizconfig-python/tests/ 2012-05-21 14:23:08 +0000
3+++ compizconfig/compizconfig-python/tests/ 2012-05-26 10:36:20 +0000
4@@ -15,7 +15,6 @@
5 self.assertTrue (plugin.LongDesc is not None)
6 self.assertTrue (plugin.Category is not None)
7 self.assertTrue (plugin.Features is not None)
8- self.assertTrue (plugin.Initialized is True)
10 if __name__ == '__main__':
11 unittest.main()


People subscribed via source and target branches