Merge lp:~compiz-team/compiz/compiz.fix_1002606 into lp:compiz/0.9.8

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 3242
Proposed branch: lp:~compiz-team/compiz/compiz.fix_1002606
Merge into: lp:compiz/0.9.8
Diff against target: 15 lines (+2/-2)
1 file modified
plugins/place/src/place.cpp (+2/-2)
To merge this branch: bzr merge lp:~compiz-team/compiz/compiz.fix_1002606
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+108454@code.launchpad.net

Description of the change

Fix a typo that was causing LP: #1002606 (widthIncBorders/heightIncBorders)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

(btw, I checked recent merges for any related typoes and didn't find any, so I think we should be safe)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Wow. How did we not notice that?...

Also, I'm not sure 'place' is working properly for me any more. But this branch doesn't seem to make it any worse.

review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

BTW, this section of the code was not under test, which is why it broke so easily. I say merge this in, but lets keep an eye on getting stuff under test before we merge it ;-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/place/src/place.cpp'
2--- plugins/place/src/place.cpp 2012-04-04 04:47:00 +0000
3+++ plugins/place/src/place.cpp 2012-06-02 11:34:26 +0000
4@@ -1197,10 +1197,10 @@
5
6 extents.left = pos.x () - window->border ().left;
7 extents.top = pos.y () - window->border ().top;
8- extents.right = extents.left + window->serverGeometry ().heightIncBorders () +
9+ extents.right = extents.left + window->serverGeometry ().widthIncBorders () +
10 (window->border ().left +
11 window->border ().right);
12- extents.bottom = extents.top + window->serverGeometry ().widthIncBorders () +
13+ extents.bottom = extents.top + window->serverGeometry ().heightIncBorders () +
14 (window->border ().top +
15 window->border ().bottom);
16

Subscribers

People subscribed via source and target branches