Compiz

lp:~compiz-team/compiz/compiz.fix_1002606

Created by Sam Spilsbury and last modified
Get this branch:
bzr branch lp:~compiz-team/compiz/compiz.fix_1002606
Members of Compiz Maintainers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Compiz Maintainers
Project:
Compiz
Status:
Merged

Recent revisions

3238. By Sam Spilsbury

Fix a typo (widthIncBorders/heightIncBorders) causing (LP: #1002606)

3237. By Daniel van Vugt

Improve the fix for LP: #1005569:
Calling CompOption::setName should not implicitly construct a new string
object every time, when the name is not changing.

This is also an alternative fix to the previous commit, but both together
don't hurt either.

3236. By Daniel van Vugt

Avoid constructing and destructing lots of strings on every single event,
which was wasting lots of CPU (LP: #1005569)

3235. By Didier Roche-Tolomelli

md LINGUAS doesn't exist, it's mnk (Mandinka in ISO 639-3)

3234. By Sam Spilsbury

Move grid plugin to google test and don't depend on the plugin for the test
(LP: #1005009)

3233. By Sam Spilsbury

Don't read plugin.Initialized and test the value.

The python bindings indicate that all this does is return whether or not
the plugin is loaded, which is user-configurable and not deterministic.

      property Initialized:
          def __get__ (self):
              return bool (self.loaded)

As such, we shouldn't be testing that value

(LP: #1004848)

3232. By Sam Spilsbury

libcompizconfig's install () commands were still using the old includedir and
libdir variables rather than their libcompizconfig_* variants. (LP: #1005176)

3231. By Sam Spilsbury

Execute the cmake files separately to ensure that DESTDIR is respected.
(LP: #1005177)

The cmake preprocessor does substitution on install (CODE) at configure time
and not install time, when DESTDIR is actually set. In order to read it
correctly, we need to execute the cmake preprocessor in the install cmake
file itself, so that DESTDIR is set when the file is preprocessed.

3230. By Sam Spilsbury

Fixes warnings that happen on clang. Clang picked up a number of things by
default, including:

1. Memset by the size of a pointer rather than by the struct itself
2. inline functions in header files declared only
3. needless casting (although a leaked KWinAdapter is just insane, not sure
   how to fix that ..)
4. Unnecessary checks for < 0 with unsigned int
5. Member methods hiding virtual functions because they were never overridden
   correclty
6. Unused isAncestorTo in decor
7. ; after if statement with block proceeding in some places
8. Incrementing a bool

3229. By Sam Spilsbury

ASSERT_EQ has a NULL expectation that doesn't work on gcc 4.7 so use
EXPECT_FALSE instead

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:compiz/0.9.8
This branch contains Public information 
Everyone can see this information.