Merge lp:~compiz-team/compiz-core/compiz-core.fix_geometry_cycling into lp:compiz-core/0.9.5

[Sam Spilsbury]

Don't allow outdated server position to move a window back if a plugin
has already requested at a point in time past when the server was told to move
the window to change the geometry without syncing the position.

This should solve the problem of plugin A doing w->move, w->syncPosition and plugin
B doing w->move (wait) w->syncPosition where we return to handleEvent in between
the move and the position sync and the server will send us a ConfigureNotify
event for the position that was last sent to the server even if a plugin
has more recently updated the current geometry, and this geometry recieved
from the server will overwrite the current plugin's working geometry that
it was going to sync anyways later and cause moveNotify to be called.

At the moment, we're just comparing timestamps from when the geometry was
last updated by a plugin and when geometry was last sent to the server. Note
that in reality, CompWindow::move should not be updating priv->geometry directly,
this should only really be allowed to be updated by the server. However, it
doesn't make sense for it to update priv->serverGeometry as that was the
geometry last sent to the server. In reality, a larger API break will be
needed in order to represent the four possible states of geometry at any given
time.

a) geometry by the compositor (current geometry, not pending to send to server)
b) geometry last sent to server
c) geometry last recieved by the server
d) current server side geometry (which must be retrieved via a round-trip
   to the server)

Note that I don't think that this change should go in the 0.9.5.x series, but we should really wait for 0.9.7

[Mirco Müller (macslow)]

I don't have my system setup to compile compiz atm, but as far as I can tell all this look ok. BTW just get into the habit of initializing any declared variables/structs (lastGeometryUpdate, lastConfigureRequest).

review: Approve

=== modified file 'src/privatewindow.h'
--- src/privatewindow.h	2011-08-23 06:16:21 +0000
+++ src/privatewindow.h	2011-08-27 05:17:02 +0000
@@ -238,6 +238,9 @@
 	XSizeHints	     sizeHints;
 	XWMHints             *hints;
 
+	struct timeval       lastGeometryUpdate;
+	struct timeval       lastConfigureRequest;
+
 	bool       inputHint;
 	bool       alpha;
 	int        width;

=== modified file 'src/window.cpp'
--- src/window.cpp	2011-08-23 13:15:20 +0000
+++ src/window.cpp	2011-08-27 05:17:02 +0000
@@ -768,6 +768,8 @@
     if (!frame)
 	return;
 
+    gettimeofday (&lastConfigureRequest, NULL);
+
     if (input.left || input.right || input.top || input.bottom)
     {
         int	   x, y, width, height;
@@ -1483,6 +1485,8 @@
 	dwidth  = gm.width () - priv->geometry.width ();
 	dheight = gm.height () - priv->geometry.height ();
 
+	gettimeofday (&priv->lastGeometryUpdate, NULL);
+
 	priv->geometry.set (gm.x (), gm.y (),
 			    gm.width (), gm.height (),
 			    gm.border ());
@@ -1505,7 +1509,13 @@
 	dx = gm.x () - priv->geometry.x ();
 	dy = gm.y () - priv->geometry.y ();
 
-	move (dx, dy);
+	/* Don't move the window here if a plugin has already updated
+	 * the geometry of that window after the last time the server
+	 * was sent a configure request since the configureNotify we
+	 * receieve here will be out of date. Instead wait for the plugin
+	 * to call syncPosition again */
+	if (TIMEVALDIFF (&priv->lastConfigureRequest, &priv->lastGeometryUpdate))
+	    move (dx, dy);
     }
 
     return true;
@@ -1719,6 +1729,8 @@
 	priv->geometry.setX (priv->geometry.x () + dx);
 	priv->geometry.setY (priv->geometry.y () + dy);
 
+	gettimeofday (&priv->lastGeometryUpdate, NULL);
+
 	priv->region.translate (dx, dy);
 	priv->inputRegion.translate (dx, dy);
 	if (!priv->frameRegion.isEmpty ())
@@ -1736,6 +1748,8 @@
     priv->serverGeometry.setX (priv->geometry.x ());
     priv->serverGeometry.setY (priv->geometry.y ());
 
+    gettimeofday (&priv->lastConfigureRequest, NULL);
+
     XMoveWindow (screen->dpy (), ROOTPARENT (this),
 		 priv->geometry.x () - priv->input.left,
 		 priv->geometry.y () - priv->input.top);
@@ -2477,6 +2491,8 @@
     {
 	XWindowChanges wc = *xwc;
 
+	gettimeofday (&lastConfigureRequest, NULL);
+
 	wc.x      -= input.left - serverGeometry.border ();
 	wc.y      -= input.top - serverGeometry.border ();
 	wc.width  += input.left + input.right + serverGeometry.border ();
@@ -5315,6 +5331,8 @@
 
     screen->insertWindow (this, aboveId);
 
+    gettimeofday (&priv->lastGeometryUpdate, NULL);
+
     priv->attrib = wa;
     priv->serverGeometry.set (priv->attrib.x, priv->attrib.y,
 			      priv->attrib.width, priv->attrib.height,
@@ -5883,6 +5901,8 @@
 	return false;
     }
 
+    gettimeofday (&lastConfigureRequest, NULL);
+
     if (attrib.override_redirect)
 	return false;