Merge lp:~compiz-team/compiz-core/compiz-core.fix_861793 into lp:compiz-core/0.9.5

Proposed by Sam Spilsbury
Status: Merged
Approved by: Jason Smith
Approved revision: 2845
Merged at revision: 2845
Proposed branch: lp:~compiz-team/compiz-core/compiz-core.fix_861793
Merge into: lp:compiz-core/0.9.5
Diff against target: 71 lines (+25/-23)
1 file modified
src/window.cpp (+25/-23)
To merge this branch: bzr merge lp:~compiz-team/compiz-core/compiz-core.fix_861793
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Review via email: mp+77431@code.launchpad.net

Description of the change

Fix LP 861793

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2011-09-27 15:45:28 +0000
3+++ src/window.cpp 2011-09-29 03:00:23 +0000
4@@ -3983,42 +3983,44 @@
5 * if serverPrev was recently restacked */
6 if (window->serverPrev)
7 {
8- bool pendingRestacks = false;
9-
10- foreach (XWCValueMask &xwcvm, sibling->priv->pendingConfigures)
11- {
12- if (xwcvm.second & (CWSibling | CWStackMode))
13- {
14- pendingRestacks = true;
15- break;
16- }
17- }
18-
19- if (!sibling && window->serverPrev)
20- {
21- XWindowChanges xwc;
22+ if (!sibling)
23+ {
24+ XWindowChanges lxwc;
25 unsigned int valueMask = CWStackMode;
26
27- xwc.stack_mode = Below;
28+ lxwc.stack_mode = Below;
29
30 /* Below with no sibling puts the window at the bottom
31 * of the stack */
32- XConfigureWindow (screen->dpy (), ROOTPARENT (window), valueMask, &xwc);
33+ XConfigureWindow (screen->dpy (), ROOTPARENT (window), valueMask, &lxwc);
34
35 if (serverFrame)
36- priv->addPendingConfigure (xwc, CWStackMode);
37+ priv->addPendingConfigure (lxwc, CWStackMode);
38
39 /* Update the list of windows last sent to the server */
40 screen->unhookServerWindow (window);
41 screen->insertServerWindow (window, 0);
42 }
43- else if (sibling->priv->id != window->serverPrev->priv->id ||
44- pendingRestacks)
45+ else if (sibling)
46 {
47- mask |= CWSibling | CWStackMode;
48-
49- xwc->stack_mode = Above;
50- xwc->sibling = ROOTPARENT (sibling);
51+ bool pendingRestacks = false;
52+
53+ foreach (XWCValueMask &xwcvm, sibling->priv->pendingConfigures)
54+ {
55+ if (xwcvm.second & (CWSibling | CWStackMode))
56+ {
57+ pendingRestacks = true;
58+ break;
59+ }
60+ }
61+
62+ if (sibling->priv->id != window->serverPrev->priv->id || pendingRestacks)
63+ {
64+ mask |= CWSibling | CWStackMode;
65+
66+ xwc->stack_mode = Above;
67+ xwc->sibling = ROOTPARENT (sibling);
68+ }
69 }
70 }
71 else if (sibling)

Subscribers

People subscribed via source and target branches