Merge lp:~compiz-team/compiz-core/compiz-core.fix_724093 into lp:compiz-core/0.9.5

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 2813
Proposed branch: lp:~compiz-team/compiz-core/compiz-core.fix_724093
Merge into: lp:compiz-core/0.9.5
Diff against target: 22 lines (+8/-2)
1 file modified
plugins/compiztoolbox/src/compiztoolbox.cpp (+8/-2)
To merge this branch: bzr merge lp:~compiz-team/compiz-core/compiz-core.fix_724093
Reviewer Review Type Date Requested Status
Robert Carr (community) Approve
Review via email: mp+74811@code.launchpad.net

Description of the change

Fixes window titles not showing up in the switcher and probably bug 724093 since the atk property was attached to the text property.

To post a comment you must log in.
Revision history for this message
Robert Carr (robertcarr) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/compiztoolbox/src/compiztoolbox.cpp'
2--- plugins/compiztoolbox/src/compiztoolbox.cpp 2011-03-14 16:12:45 +0000
3+++ plugins/compiztoolbox/src/compiztoolbox.cpp 2011-09-09 15:06:40 +0000
4@@ -129,10 +129,16 @@
5 CompOption::Vector opts;
6 CompOption::Value v;
7
8- if (focus && selectedWindow && !selectedWindow->destroyed ())
9+ if (selectedWindow && !selectedWindow->destroyed ())
10 {
11 selectedWindowId = selectedWindow->id ();
12- selectedWindow->moveInputFocusTo ();
13+
14+ /* FIXME: Changing the input focus here will
15+ * screw up the ordering of windows in
16+ * the switcher, so we probably want to avoid that
17+ */
18+ if (focus)
19+ selectedWindow->moveInputFocusTo ();
20 }
21
22 v = CompOption::Value ((int) selectedWindowId);

Subscribers

People subscribed via source and target branches