lp:~colin-king/ecryptfs/minor-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ecryptfs at revision 780

eCryptfs: Pending requested 2013-07-05

Diff: 179 lines (+20/-45)

6 files modified

configure.ac (+1/-1)
src/daemon/main.c (+1/-1)
src/libecryptfs/cmd_ln_parser.c (+12/-5)
src/libecryptfs/decision_graph.c (+1/-19)
src/utils/mount.ecryptfs.c (+1/-14)
tests/kernel/trunc-file/test.c (+4/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

787. By Colin Ian King on 2013-07-05

* src/libecryptfs/decision_graph.c
  - remove set_exit_param_node_for_arr(), it is not used anymore and it
    also is buggy. Increment LIBECRYPTFS_LT_CURRENT

786. By Colin Ian King on 2013-07-05

* src/libecryptfs/cmd_ln_parser.c
  - don't do strlen() before a null pointer check on tok

785. By Colin Ian King on 2013-07-05

* src/utils/mount.ecryptfs.c
  - remove dead code that cannot be reached

784. By Colin Ian King on 2013-07-05

* tests/kernel/trunc-file/test.c
  - comparing len against SSIZE_MAX makes no sense as this is always going
    to be false. Instead, compare against the max size in terms of K bytes.

783. By Colin Ian King on 2013-07-05

* src/libecryptfs/cmd_ln_parser.c
  - we used to bail out early if tok was not-null and an empty string
    however static analysis code checkers complain that subseqent accesses
    to tok may be assuming tok is non-null. At present, tok is always
    passed in as a string on the stack so it is never null, but we can't
    guarantee that in the future. So to be safe, bail out early if tok
    is null. This is safer and a minor extra overhead.

782. By Colin Ian King on 2013-07-05

* src/daemon/main.c
  - we should dup2 on the fd rather than 3 times on file descriptor 0

781. By Colin Ian King on 2013-07-05

* src/libecryptfs/cmd_ln_parser.c
  - free value, name on error exit paths in process_comma_tok

780. By Colin Ian King on 2013-07-05

* src/libecryptfs/decision_graph.c
  - iterate over parameters if params is not NULL, otherwise we can
    hit a NULL pointer deference on params. This is unlikely since
    num_params should be zero if params is NULL.

779. By Tyler Hicks on 2013-06-28

* src/utils/ecryptfs_rewrap_passphrase.c:
  - Handle errors when interactively reading the new wrapping passphrase
    and the confirmation from stdin. Fixes a segfault (invalid memory read)
    in ecryptfs-rewrap-passphrase if there was an error while reading either
    of these passphrases.
  - Minor code cleanups

778. By Tyler Hicks on 2013-06-11

* configure.ac: Add libtool versioning instructions for libecryptfs