Merge lp:~colin-king/ecryptfs/minor-bugfixes into lp:ecryptfs

Proposed by Colin Ian King
Status: Merged
Approved by: Tyler Hicks
Approved revision: 834
Merged at revision: 833
Proposed branch: lp:~colin-king/ecryptfs/minor-bugfixes
Merge into: lp:ecryptfs
Diff against target: 28 lines (+2/-2)
2 files modified
src/utils/mount.ecryptfs.c (+1/-1)
tests/kernel/lp-509180/test.c (+1/-1)
To merge this branch: bzr merge lp:~colin-king/ecryptfs/minor-bugfixes
Reviewer Review Type Date Requested Status
Tyler Hicks Approve
Review via email: mp+228258@code.launchpad.net

Description of the change

Just a couple of minor fixes found with the latest new version of CoverityScan

To post a comment you must log in.
Revision history for this message
Tyler Hicks (tyhicks) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/utils/mount.ecryptfs.c'
--- src/utils/mount.ecryptfs.c 2014-02-28 14:32:05 +0000
+++ src/utils/mount.ecryptfs.c 2014-07-25 09:17:22 +0000
@@ -311,10 +311,10 @@
311 }311 }
312 }312 }
313 } else {313 } else {
314 rc = ECANCELED;
314 if (strcmp(yesno,"no"))315 if (strcmp(yesno,"no"))
315 rc = -EINVAL;316 rc = -EINVAL;
316 printf("Aborting mount.\n");317 printf("Aborting mount.\n");
317 rc = ECANCELED;
318 goto out;318 goto out;
319 }319 }
320 }320 }
321321
=== modified file 'tests/kernel/lp-509180/test.c'
--- tests/kernel/lp-509180/test.c 2014-07-10 21:53:29 +0000
+++ tests/kernel/lp-509180/test.c 2014-07-25 09:17:22 +0000
@@ -80,7 +80,7 @@
80{80{
81 const char *name = "user.ecryptfs";81 const char *name = "user.ecryptfs";
82 unsigned char *value = NULL;82 unsigned char *value = NULL;
83 size_t nread, size = 0;83 ssize_t nread, size = 0;
84 int rc = TEST_ERROR;84 int rc = TEST_ERROR;
8585
86 size = fgetxattr(fd, name, value, size);86 size = fgetxattr(fd, name, value, size);

Subscribers

People subscribed via source and target branches