lp:~colin-king/ecryptfs/coverity-fixes
- Get this branch:
- bzr branch lp:~colin-king/ecryptfs/coverity-fixes
Branch merges
- eCryptfs: Pending requested
-
Diff: 88 lines (+24/-11)3 files modifiedsrc/key_mod/ecryptfs_key_mod_passphrase.c (+7/-6)
src/libecryptfs/main.c (+11/-1)
src/pam_ecryptfs/pam_ecryptfs.c (+6/-4)
Branch information
Recent revisions
- 794. By Colin Ian King
-
* don't use strtok to strip off trailing newline
- Coverity Scan complains that strtok will return a pointer that is
different to that of mnt which will cause issues when it is free'd. In
fact, strtok first time around always returns mnt in this case. Anyhow,
since strtok is a little opaque I reworked it and Coverity is now happy. - 793. By Colin Ian King
-
* src/key_
mod/ecryptfs_ key_mod_ passphrase. c
move file_head allocation to after the passphrase handling so that
we can avoid messy free'ing of file_head if things go wrong. This change
fixes a memory leak on file_head. - 792. By Colin Ian King
-
* src/pam_
ecryptfs/ pam_ecryptfs. c
- no need to check for error return on geteuid and getegid as these
never fail - 787. By Colin Ian King
-
* src/libecryptfs
/cmd_ln_ parser. c
fix memory leak on name, the loop is doing multiple mallocs but not
freeing previos allocations - 785. By Colin Ian King
-
* src/pam_
ecryptfs/ pam_ecryptfs. c
do not close a negative file descriptor if an open error occurs
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:ecryptfs