Merge lp:~colin-king/apport/acpi-tables-remove into lp:apport

[Colin Ian King]

Currently apport collects a bunch of ACPI tables for kernel bugs to enable the kernel team to check if specific issues are related to malformed table data. However, for the majority of bugs we look at this data is superflous and if we really require it we should request it on a per bug basis. I therefore propose this change to remove the automatic ACPI table collection.

[Martin Pitt (pitti)]

Hm, I'd actually like the code to stay in trunk, so that package hooks can use it if they want to.

How about we just drop that from ./data/package-hooks/source_linux.py in the packaging branch? We need to do that anyway.

review: Disapprove

[Martin Pitt (pitti)]

See http://bazaar.launchpad.net/~ubuntu-core-dev/ubuntu/quantal/apport/ubuntu/revision/2098

Unmerged revisions

2502. By Colin Ian King on 2012-10-01

Remove ACPI data gathering, not required for most kernel issues

=== removed file 'data/dump_acpi_tables.py'
--- data/dump_acpi_tables.py	2012-06-11 09:44:13 +0000
+++ data/dump_acpi_tables.py	1970-01-01 00:00:00 +0000
@@ -1,54 +0,0 @@
-#!/usr/bin/python
-
-import os, sys, stat
-
-
-def dump_acpi_table(filename, tablename, out):
-    '''Dump a single ACPI table'''
-
-    out.write('%s @ 0x00000000\n' % tablename)
-    n = 0
-    f = open(filename, 'rb')
-    hex_str = ''
-    try:
-        byte = f.read(1)
-        while byte != b'':
-            val = ord(byte)
-            if (n & 15) == 0:
-                hex_str = '  %4.4x: ' % n
-                ascii_str = ''
-
-            hex_str = hex_str + '%2.2x ' % val
-
-            if (val < 32) or (val > 126):
-                ascii_str = ascii_str + '.'
-            else:
-                ascii_str = ascii_str + chr(val)
-            n = n + 1
-            if (n & 15) == 0:
-                out.write('%s %s\n' % (hex_str, ascii_str))
-            byte = f.read(1)
-    finally:
-        for i in range(n & 15, 16):
-            hex_str = hex_str + '   '
-
-        if (n & 15) != 15:
-            out.write('%s %s\n' % (hex_str, ascii_str))
-        f.close()
-    out.write('\n')
-
-
-def dump_acpi_tables(path, out):
-    '''Dump ACPI tables'''
-
-    tables = os.listdir(path)
-    for tablename in tables:
-        pathname = os.path.join(path, tablename)
-        mode = os.stat(pathname).st_mode
-        if stat.S_ISDIR(mode):
-            dump_acpi_tables(pathname, out)
-        else:
-            dump_acpi_table(pathname, tablename, out)
-
-if os.path.isdir('/sys/firmware/acpi/tables'):
-    dump_acpi_tables('/sys/firmware/acpi/tables', sys.stdout)