Merge lp:~codygarver/wingpanel/packaging-fix-1170094 into lp:~elementary-os/wingpanel/deb-packaging-freya

[Cody Garver]

[lp:~codygarver/wingpanel/packaging-fix-1170094]

12. By Cody Garver on 2013-04-17

Fix my email.

[Sergey "Shnatsel" Davidoff (shnatsel)]

In fact, no need to bump it to 2:.., 1:.. is fine because {debupstream} we use for recipes is not pick up the epoch version.

By the way, I still have to revert 1:.. on many branches...

review: Needs Fixing

[Sergey "Shnatsel" Davidoff (shnatsel)]

Also, why the valac version bump?

[lp:~codygarver/wingpanel/packaging-fix-1170094]

13. By Cody Garver on 2013-04-17

Don't bump epoch.

[Cody Garver (codygarver)]

I reduced the epoch to 1 as requested. The valac bump is for consistency with other branches that request that. It's what valac --version prints from valac-0.16 package.

[Sergey "Shnatsel" Davidoff (shnatsel)]

0.16.0 is the latest version available from Ubuntu repos, so you make the package unbuildable without a valac backport. You'd better have a a good reason for doing that!

review: Needs Information

[Victor Martinez (victored)]

Hey Cody,

I actually agree with Sergey regarding valac. As far as my knowledge goes, we are currently not depending on any *.vapi file exclusively available to valac 0.16.1, so everything should build fine with vala 0.16.0

Let's bump the version when absolutely necessary. We'd also need to change the version in CMakeLists.txt to request 0.16.0 again.

Please let me know what you think.

[lp:~codygarver/wingpanel/packaging-fix-1170094]

14. By Cody Garver on 2013-04-20

Revert valac version bump.

[Cody Garver (codygarver)]

Reverted valac version bump.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Looks good to me now. I'll merge this and change {debupstream} to {debversion} in the recipe.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2013-04-01 18:08:53 +0000
+++ debian/changelog	2013-04-20 17:35:30 +0000
@@ -1,3 +1,9 @@
+wingpanel (1:0.2.2) precise; urgency=low
+
+  * New upstream release.
+
+ -- Cody Garver <[e-mail]>  Wed, 17 Apr 2013 14:58:56 -0500
+
 wingpanel (1:0.1) oneiric; urgency=low
 
   * Initial Release.

=== modified file 'debian/control'
--- debian/control	2013-03-27 07:29:32 +0000
+++ debian/control	2013-04-20 17:35:30 +0000
@@ -10,7 +10,7 @@
                libgtk-3-dev,
                libindicator3-dev (>= 0.3.90),
                valac-0.16 | valac (>= 0.16)
-Standards-Version: 3.9.1
+Standards-Version: 3.9.3
 Homepage: https://launchpad.net/wingpanel
 Vcs-Bzr: https://code.launchpad.net/~wingpanel-devs/wingpanel/wingpanel-gtk3
 Vcs-Browser: http://bazaar.launchpad.net/~wingpanel-devs/wingpanel/wingpanel-gtk3/files