Merge lp:~codygarver/switchboard/fix-831581 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Cody Garver
Status: Merged
Approved by: Cody Garver
Approved revision: 389
Merged at revision: 389
Proposed branch: lp:~codygarver/switchboard/fix-831581
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 19 lines (+1/-1)
1 file modified
src/Switchboard.vala (+1/-1)
To merge this branch: bzr merge lp:~codygarver/switchboard/fix-831581
Reviewer Review Type Date Requested Status
Danielle Foré Approve
elementary Pantheon team Pending
Review via email: mp+169577@code.launchpad.net

Commit message

Drop appmenu and add 6 px margin to the right of search box to fix bug #831581.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Yes!

review: Approve
Revision history for this message
Julien Spautz (julien-spautz) wrote :

Won't this make the about dialog unaccessible? We should consider putting it in the quicklist.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Switchboard.vala'
2--- src/Switchboard.vala 2013-01-08 15:21:51 +0000
3+++ src/Switchboard.vala 2013-06-15 00:39:25 +0000
4@@ -503,6 +503,7 @@
5 search_box.sensitive = (count_plugs () > 0);
6 var find_toolitem = new Gtk.ToolItem ();
7 find_toolitem.add(search_box);
8+ find_toolitem.margin_right = 6;
9
10 // Focus typing to the search bar
11 main_window.key_press_event.connect ((event) => {
12@@ -524,7 +525,6 @@
13 toolbar.insert (progress_toolitem, -1);
14 toolbar.insert (rspace, -1);
15 toolbar.insert (find_toolitem, -1);
16- toolbar.insert (create_appmenu (new Gtk.Menu ()), -1);
17 }
18
19 public override void activate () {

Subscribers

People subscribed via source and target branches

to all changes: