Merge lp:~codygarver/switchboard/fix-1027662 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Cody Garver
Status: Merged
Merged at revision: 263
Proposed branch: lp:~codygarver/switchboard/fix-1027662
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 59 lines (+8/-5)
4 files modified
Switchboard/switchboard-app.vala (+1/-1)
Switchboard/switchboard-resources.vala (+1/-1)
data/switchboard.desktop (+1/-2)
po/switchboard.pot (+5/-1)
To merge this branch: bzr merge lp:~codygarver/switchboard/fix-1027662
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+116164@code.launchpad.net
To post a comment you must log in.
257. By Cody Garver

Change window title from "Switchboard" to _("System Settings").

Revision history for this message
Danielle Foré (danrabbit) wrote :

I'm +1 on changing the title. It seems kind of odd to change the .desktop and not the window title.

258. By Cody Garver

Merge with trunk.

259. By Cody Garver

Updated POT file.

260. By Cody Garver

Hardcode program_name to Switchboard so that About does NOT display System Settings as the app's name.

261. By Cody Garver

Merge trunk.

Revision history for this message
Cody Garver (codygarver) wrote :

I hereby approve my own work.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-07-23 00:18:24 +0000
3+++ Switchboard/switchboard-app.vala 2012-07-23 00:45:20 +0000
4@@ -24,7 +24,7 @@
5
6 construct {
7 application_id = "org.elementary.Switchboard";
8- program_name = APP_TITLE;
9+ program_name = "Switchboard";
10 app_years = "2011-2012";
11
12 build_version = VERSION;
13
14=== modified file 'Switchboard/switchboard-resources.vala'
15--- Switchboard/switchboard-resources.vala 2012-07-23 00:21:12 +0000
16+++ Switchboard/switchboard-resources.vala 2012-07-23 00:45:20 +0000
17@@ -1,6 +1,6 @@
18 namespace Switchboard {
19
20- public const string APP_TITLE = "Switchboard";
21+ public const string APP_TITLE = _("System Settings");
22 public const string COPYRIGHT = "Copyright (C) 2011-2012 Avi Romanoff";
23 public const string WEBSITE = "https://launchpad.net/switchboard";
24 public const string VERSION = "0.9";
25
26=== modified file 'data/switchboard.desktop'
27--- data/switchboard.desktop 2012-06-07 06:21:02 +0000
28+++ data/switchboard.desktop 2012-07-23 00:45:20 +0000
29@@ -1,8 +1,7 @@
30 [Desktop Entry]
31 Type=Application
32 Version=0.8
33-Name=Switchboard
34-GenericName=Settings Center
35+Name=System Settings
36 Comment=Change system and user settings
37 Exec=switchboard
38 Icon=preferences-desktop
39
40=== modified file 'po/switchboard.pot'
41--- po/switchboard.pot 2012-07-22 22:23:37 +0000
42+++ po/switchboard.pot 2012-07-23 00:45:20 +0000
43@@ -8,7 +8,7 @@
44 msgstr ""
45 "Project-Id-Version: PACKAGE VERSION\n"
46 "Report-Msgid-Bugs-To: \n"
47-"POT-Creation-Date: 2012-07-22 17:23-0500\n"
48+"POT-Creation-Date: 2012-07-22 18:44-0500\n"
49 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
50 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
51 "Language-Team: LANGUAGE <LL@li.org>\n"
52@@ -106,3 +106,7 @@
53 #: /home/codygarver/switchboard/po/../Switchboard//switchboard-app.vala:523
54 msgid "Switchboard already running. Exiting.."
55 msgstr ""
56+
57+#: /home/codygarver/switchboard/po/../Switchboard//switchboard-resources.vala:3
58+msgid "System Settings"
59+msgstr ""

Subscribers

People subscribed via source and target branches

to all changes: