Merge lp:~codygarver/switchboard/fix-1020180 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Cody Garver
Status: Merged
Merged at revision: 256
Proposed branch: lp:~codygarver/switchboard/fix-1020180
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 43 lines (+4/-4)
2 files modified
Switchboard/switchboard-app.vala (+3/-3)
Switchboard/switchboard-categoryview.vala (+1/-1)
To merge this branch: bzr merge lp:~codygarver/switchboard/fix-1020180
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Review via email: mp+116170@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

Looks fine to me. Could you please make line 40 on switchboard-categoryview.vala translatable too?

review: Approve
257. By Cody Garver

Made alert string translatable.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-06-26 11:53:10 +0000
3+++ Switchboard/switchboard-app.vala 2012-07-22 22:20:22 +0000
4@@ -153,7 +153,7 @@
5 any_plugs = true;
6
7 if (!any_plugs) {
8- show_alert(_("No plugs found"), _("Install some and re-launch Switchboard"), Gtk.MessageType.WARNING);
9+ show_alert(_("No settings found"), _("Install some and re-launch Switchboard"), Gtk.MessageType.WARNING);
10 search_box.sensitive = false;
11 }
12
13@@ -166,7 +166,7 @@
14 }
15 }
16 if (!found) {
17- critical ("Couldn't find %s among the loaded plugs.", plug_to_open);
18+ critical ("Couldn't find %s among the loaded settings.", plug_to_open);
19 }
20 }
21
22@@ -456,7 +456,7 @@
23 progress_toolitem.set_expand(true);
24
25 // Searchbar
26- search_box = new Granite.Widgets.SearchBar (_("Search Plugs"));
27+ search_box = new Granite.Widgets.SearchBar (_("Search Settings"));
28 search_box.primary_icon_stock = "gtk-find";
29 search_box.activate.connect(() => search_box_activated());
30 search_box.changed.connect(() => {
31
32=== modified file 'Switchboard/switchboard-categoryview.vala'
33--- Switchboard/switchboard-categoryview.vala 2012-06-18 13:50:04 +0000
34+++ Switchboard/switchboard-categoryview.vala 2012-07-22 22:20:22 +0000
35@@ -134,7 +134,7 @@
36 }
37 }
38 if (!any_found) {
39- switchboard.show_alert("No plugs found", "Try changing your search terms", Gtk.MessageType.INFO);
40+ switchboard.show_alert(_("No settings found"), _("Try changing your search terms"), Gtk.MessageType.INFO);
41 } else {
42 switchboard.hide_alert();
43 }

Subscribers

People subscribed via source and target branches

to all changes: