Merge lp:~codygarver/switchboard-plug-security-privacy/move-chat-logs-top into lp:~elementary-apps/switchboard-plug-security-privacy/trunk

Proposed by Cody Garver
Status: Merged
Approved by: Danielle Foré
Approved revision: 61
Merged at revision: 67
Proposed branch: lp:~codygarver/switchboard-plug-security-privacy/move-chat-logs-top
Merge into: lp:~elementary-apps/switchboard-plug-security-privacy/trunk
Diff against target: 25 lines (+2/-2)
1 file modified
src/TrackPanel.vala (+2/-2)
To merge this branch: bzr merge lp:~codygarver/switchboard-plug-security-privacy/move-chat-logs-top
Reviewer Review Type Date Requested Status
Corentin Noël Needs Fixing
Review via email: mp+229349@code.launchpad.net

Commit message

Move Chat Logs to top of list of record sources

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

English should be treated as any other language, please implement a sort function.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/TrackPanel.vala'
2--- src/TrackPanel.vala 2014-04-25 09:38:47 +0000
3+++ src/TrackPanel.vala 2014-08-02 22:43:28 +0000
4@@ -296,13 +296,13 @@
5 record_grid.attach (scrolled, 0, 1, 1, 1);
6 attach (record_grid, 1, 1, 1, 1);
7
8+ set_inclue_iter_to_liststore (list_store, _("Chat Logs"), "internet-chat", Zeitgeist.NMO.IMMESSAGE);
9 set_inclue_iter_to_liststore (list_store, _("Documents"), "x-office-document", Zeitgeist.NFO.DOCUMENT);
10 set_inclue_iter_to_liststore (list_store, _("Music"), "audio-x-generic", Zeitgeist.NFO.AUDIO);
11 set_inclue_iter_to_liststore (list_store, _("Pictures"), "image-x-generic", Zeitgeist.NFO.IMAGE);
12 set_inclue_iter_to_liststore (list_store, _("Presentations"), "x-office-presentation", Zeitgeist.NFO.PRESENTATION);
13 set_inclue_iter_to_liststore (list_store, _("Spreadsheets"), "x-office-spreadsheet", Zeitgeist.NFO.SPREADSHEET);
14 set_inclue_iter_to_liststore (list_store, _("Videos"), "video-x-generic", Zeitgeist.NFO.VIDEO);
15- set_inclue_iter_to_liststore (list_store, _("Chat Logs"), "internet-chat", Zeitgeist.NMO.IMMESSAGE);
16 }
17
18 private void set_inclue_iter_to_liststore (Gtk.ListStore list_store, string name, string icon, string file_type) {
19@@ -461,4 +461,4 @@
20 NotColumns.IS_APP, false);
21 });
22 }
23-}
24\ No newline at end of file
25+}

Subscribers

People subscribed via source and target branches

to all changes: