Merge lp:~codygarver/switchboard-plug-display/rotation-strings-changes into lp:~elementary-apps/switchboard-plug-display/trunk

Proposed by Cody Garver
Status: Merged
Approved by: Cody Garver
Approved revision: 41
Merged at revision: 45
Proposed branch: lp:~codygarver/switchboard-plug-display/rotation-strings-changes
Merge into: lp:~elementary-apps/switchboard-plug-display/trunk
Diff against target: 31 lines (+5/-5)
1 file modified
src/DisplayPopover.vala (+5/-5)
To merge this branch: bzr merge lp:~codygarver/switchboard-plug-display/rotation-strings-changes
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+228831@code.launchpad.net

Commit message

More human-friendly strings for Rotations, changed order.

Description of the change

I still don't like "Counterclockwise". It looks long and.. concatenated. But I couldn't think of a better alternative.

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

You changed the order of strings so it's not corresponding to what it does.
The label rotation seems to be inverted for clockwise and counterclockwise

review: Needs Fixing
41. By Cody Garver

Also change rotation order

Revision history for this message
Corentin Noël (tintou) wrote :

You got it

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/DisplayPopover.vala'
2--- src/DisplayPopover.vala 2014-07-30 02:20:42 +0000
3+++ src/DisplayPopover.vala 2014-07-30 12:28:43 +0000
4@@ -258,16 +258,16 @@
5
6 Gnome.RRRotation[] rotations = {
7 Gnome.RRRotation.ROTATION_0,
8+ Gnome.RRRotation.ROTATION_270,
9 Gnome.RRRotation.ROTATION_90,
10- Gnome.RRRotation.ROTATION_270,
11 Gnome.RRRotation.ROTATION_180
12 };
13
14 string[] desc = {
15- _("Normal"),
16+ _("None"),
17+ _("Clockwise"),
18 _("Counterclockwise"),
19- _("Clockwise"),
20- _("180 Degrees")
21+ _("Flipped")
22 };
23
24 #if HAS_GNOME312
25@@ -297,4 +297,4 @@
26 rotation.sensitive = n_rotations > 0;
27 rotation.active_id = ((int) info.get_rotation ()).to_string ();
28 }
29-}
30\ No newline at end of file
31+}

Subscribers

People subscribed via source and target branches

to all changes: