Merge lp:~codygarver/scratch/grammar-fixes into lp:~registry/scratch/scratch

Proposed by Cody Garver
Status: Merged
Approved by: Mario Guerriero
Approved revision: 168
Merge reported by: Mario Guerriero
Merged at revision: not available
Proposed branch: lp:~codygarver/scratch/grammar-fixes
Merge into: lp:~registry/scratch/scratch
Diff against target: 115 lines (+12/-12)
6 files modified
src/Dialogs/save_dialog.vala (+1/-1)
src/Widgets/menu.vala (+4/-4)
src/Widgets/notebook.vala (+2/-2)
src/Widgets/share_menu.vala (+2/-2)
src/Widgets/toolbar.vala (+1/-1)
src/main_window.vala (+2/-2)
To merge this branch: bzr merge lp:~codygarver/scratch/grammar-fixes
Reviewer Review Type Date Requested Status
xapantu (community) Approve
Review via email: mp+75212@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Double check line 161 of src/Widgets/toolbar.vala

Revision history for this message
xapantu (xapantu) wrote :

Thanks for these changes, really appreciated :)

I don't have the time to merge your branch right now, but I am sure someone will merge your branch ASAP :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs/save_dialog.vala'
2--- src/Dialogs/save_dialog.vala 2011-08-10 17:52:09 +0000
3+++ src/Dialogs/save_dialog.vala 2011-09-13 15:50:45 +0000
4@@ -41,7 +41,7 @@
5
6 caller = callertab;
7
8- label = new Label(_("Changes on this file aren't saved.") + "\n" + _("Do you want to save changes before close this file?"));
9+ label = new Label(_("Changes to this file haven't been saved.") + "\n" + _("Do you want to save changes before closing this file?"));
10 image = new Image.from_stock(Stock.DIALOG_WARNING, IconSize.DIALOG);
11
12 headbox = new Box(Orientation.HORIZONTAL, 10);
13
14=== modified file 'src/Widgets/menu.vala'
15--- src/Widgets/menu.vala 2011-08-31 20:30:52 +0000
16+++ src/Widgets/menu.vala 2011-09-13 15:50:45 +0000
17@@ -41,9 +41,9 @@
18
19 public void create () {
20
21- view = new MenuItem.with_label (_("Add a new view"));
22+ view = new MenuItem.with_label (_("Add New View"));
23
24- remove_view = new MenuItem.with_label (_("Remove current view"));
25+ remove_view = new MenuItem.with_label (_("Remove Current View"));
26 if (window.split_view != null) {
27 if (window.split_view.total_view <= 1) remove_view.set_sensitive(false);
28 else remove_view.set_sensitive(true);
29@@ -55,9 +55,9 @@
30
31 preferences = new ImageMenuItem.from_stock (Stock.PREFERENCES, null);
32
33- sidebar_visible = new CheckMenuItem.with_label (_("Show sidebar"));
34+ sidebar_visible = new CheckMenuItem.with_label (_("Show Sidebar"));
35 settings.schema.bind("sidebar-visible", sidebar_visible, "active", SettingsBindFlags.DEFAULT);
36- context_visible = new CheckMenuItem.with_label (_("Show context view"));
37+ context_visible = new CheckMenuItem.with_label (_("Show Context View"));
38 settings.schema.bind("context-visible", context_visible, "active", SettingsBindFlags.DEFAULT);
39
40 context_visible.sensitive = false;
41
42=== modified file 'src/Widgets/notebook.vala'
43--- src/Widgets/notebook.vala 2011-09-12 09:47:58 +0000
44+++ src/Widgets/notebook.vala 2011-09-13 15:50:45 +0000
45@@ -337,12 +337,12 @@
46
47 public ScratchWelcome(ScratchNotebook caller) {
48
49- base(_("No files opened."), _("Open a file to start editing"));
50+ base(_("No files are open."), _("Open a file to begin editing"));
51
52 notebook = caller;
53
54 append(Stock.OPEN, _("Open file"), _("open a saved file"));
55- append(Stock.NEW, _("New file"), _("create an new empty file"));
56+ append(Stock.NEW, _("New file"), _("create a new empty file"));
57 this.activated.connect (on_activated);
58
59 show_all();
60
61=== modified file 'src/Widgets/share_menu.vala'
62--- src/Widgets/share_menu.vala 2011-08-29 19:57:30 +0000
63+++ src/Widgets/share_menu.vala 2011-09-13 15:50:45 +0000
64@@ -36,7 +36,7 @@
65 this.window = window;
66
67 /*pastebin = new MenuItem.with_label (_("Upload to Pastebin..."));*/
68- share_email = new MenuItem.with_label (_("Share via email..."));
69+ share_email = new MenuItem.with_label (_("Share via Email..."));
70
71 /*append (pastebin);*/
72 append (share_email);
73@@ -51,7 +51,7 @@
74 GLib.Process.spawn_command_line_sync ("postler mailto:?attach=" + window.current_tab.filename);
75 }
76 else {
77- warning ("To share the file you need to save it!");
78+ warning ("To share the file you need to save it first!");
79 }
80 });
81
82
83=== modified file 'src/Widgets/toolbar.vala'
84--- src/Widgets/toolbar.vala 2011-09-12 17:14:05 +0000
85+++ src/Widgets/toolbar.vala 2011-09-13 15:50:45 +0000
86@@ -158,7 +158,7 @@
87 combobox.append ("fortran", "Fortran");
88 combobox.append ("gettext-translation", "Gettext");
89 combobox.append ("html", "HTML");
90- combobox.append ("ini", "ini");
91+ combobox.append ("ini", "INI");
92 combobox.append ("java", "Java");
93 combobox.append ("js", "JavaScript");
94 combobox.append ("latex", "Latex");
95
96=== modified file 'src/main_window.vala'
97--- src/main_window.vala 2011-09-13 14:30:55 +0000
98+++ src/main_window.vala 2011-09-13 15:50:45 +0000
99@@ -697,7 +697,7 @@
100 FileUtils.get_contents (filename, out text);
101 text = text.locale_to_utf8 (len, out r, out w); //TODO:fix it
102 } catch (Error e) {
103- status.set_text (_("The file cannot be opened"));
104+ status.set_text (_("The file could not be opened"));
105 }
106 //get the filename from strig filename =)
107 var name = Filename.display_basename (filename);
108@@ -746,7 +746,7 @@
109
110 if (!can_write (filename)) {
111 debug ("Opening a file wich is Read Only");
112- status.set_text (_("The file is under 'Read Only' permissions"));
113+ status.set_text (_("The file is 'Read Only'"));
114 current_tab.text_view.editable = false;
115 }
116

Subscribers

People subscribed via source and target branches