Files

Merge lp:~codygarver/pantheon-files/fix-1063970 into lp:~elementary-apps/pantheon-files/trunk

  1. fix-1063970
  2. Merge into trunk
Proposed by Cody Garver
Status: Merged
Merged at revision: 1060
Proposed branch: lp:~codygarver/pantheon-files/fix-1063970
Merge into: lp:~elementary-apps/pantheon-files/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
data/pantheon-files.desktop.in (+1/-0)
To merge this branch: bzr merge lp:~codygarver/pantheon-files/fix-1063970
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Sergey "Shnatsel" Davidoff Pending
Review via email: mp+136008@code.launchpad.net

Description of the change

This is the furthest the .desktop could be modified to please desktop-validator-tool.

We need to make sure that removing the "old" mimetypes are not harmful to the OS's defaults. Maybe Sergey has a useful opinion.

To post a comment you must log in.
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Keywords are a nice addition, but my opinion on the validator complaints is "screw it".
We're making things that work, not things that are theoretically kosher.

lp:~codygarver/pantheon-files/fix-1063970 updated
1036. By Cody Garver

Restore mimetypes.

Revision history for this message
Cody Garver (codygarver) wrote :

Only merged keywords.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/pantheon-files.desktop.in'
2--- data/pantheon-files.desktop.in 2012-11-24 12:12:27 +0000
3+++ data/pantheon-files.desktop.in 2012-12-23 21:57:21 +0000
4@@ -1,6 +1,7 @@
5 [Desktop Entry]
6 Name=Files
7 Comment=Browse your files
8+Keywords=folder;manager;explore;disk;filesystem;
9 GenericName=File Manager
10 Exec=pantheon-files %U
11 Icon=system-file-manager

Subscribers

People subscribed via source and target branches

to all changes: