Merge lp:~codygarver/granite/fix-1293284 into lp:~elementary-pantheon/granite/granite

[Cody Garver]

Deprecate DecoratedWindow and LightWindow to fix bug #1293284

[Sergey "Shnatsel" Davidoff (shnatsel)]

Corentin already complained about something we deprecated "because it's implemented upstream" while the upstream implementation was not sufficient for our needs: https://plus.google.com/u/0/107345637861329011169/posts/5iVNoV3BouZ

So I'd rather not deprecate anything until half the apps using this widget actually migrate to Gtk.Dialog.

review: Needs Information

[Victor Martinez (victored)]

Hmm, DecoratedWindow and LightWindow don't do anything that cannot be accomplished using Gtk.Dialog + client-side decorations.

The only thing we'll miss is the overlay close button in the top-left corner.

review: Approve

[Sergey "Shnatsel" Davidoff (shnatsel)]

review: Abstain

=== modified file 'lib/Widgets/DecoratedWindow.vala'
--- lib/Widgets/DecoratedWindow.vala	2013-11-16 20:24:25 +0000
+++ lib/Widgets/DecoratedWindow.vala	2014-04-09 05:29:33 +0000
@@ -24,6 +24,7 @@
     /**
      * This class is a standard decorated window.
      */
+    [Deprecated (replacement = "Gtk.Dialog", since = "0.3")]
     public class DecoratedWindow : CompositedWindow {
 
         const string DECORATED_WINDOW_FALLBACK_STYLESHEET = """

=== modified file 'lib/Widgets/LightWindow.vala'
--- lib/Widgets/LightWindow.vala	2014-04-05 11:07:27 +0000
+++ lib/Widgets/LightWindow.vala	2014-04-09 05:29:33 +0000
@@ -26,6 +26,7 @@
      *
      * {{../../doc/images/LightWindow.png}}
      */
+    [Deprecated (replacement="Gtk.Dialog", since = "0.3")]
     public class LightWindow : DecoratedWindow {
 
         /**