Granite

Merge lp:~codygarver/granite/fix-1232569 into lp:~elementary-pantheon/granite/granite

  1. fix-1232569
  2. Merge into granite
Proposed by Cody Garver
Status: Merged
Approved by: David Gomes
Approved revision: 655
Merged at revision: 655
Proposed branch: lp:~codygarver/granite/fix-1232569
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 11 lines (+1/-0)
1 file modified
lib/Widgets/StaticNotebook.vala (+1/-0)
To merge this branch: bzr merge lp:~codygarver/granite/fix-1232569
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+198008@code.launchpad.net

Commit message

Deprecate StaticNotebook. Developers should use Gtk.Stack (Gtk >= 3.10) instead.

Description of the change

Is that the right string in quotes to echo?

FYI, when you compile an app that uses StaticNotebook it prints

warning: Granite.Widgets.StaticNotebook has been deprecated since 0.3. Use Gtk.Stack

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/StaticNotebook.vala'
2--- lib/Widgets/StaticNotebook.vala 2013-03-20 15:42:25 +0000
3+++ lib/Widgets/StaticNotebook.vala 2013-12-06 08:54:26 +0000
4@@ -22,6 +22,7 @@
5 /**
6 * This class provides an easy way to manage tabs.
7 */
8+ [Deprecated (replacement = "Gtk.Stack", since = "0.3")]
9 public class StaticNotebook : Gtk.Box {
10
11 private Gtk.Notebook notebook;

Subscribers

People subscribed via source and target branches