elementary OS

Merge lp:~codygarver/elementaryos/seeds-add-notifyosd-theme into lp:~elementary-os/elementaryos/elementary-seeds.precise

  1. seeds-add-notifyosd-theme
  2. Merge into elementary-seeds.precise
Proposed by Cody Garver
Status: Merged
Merged at revision: 2015
Proposed branch: lp:~codygarver/elementaryos/seeds-add-notifyosd-theme
Merge into: lp:~elementary-os/elementaryos/elementary-seeds.precise
Diff against target: 9 lines (+1/-0)
1 file modified
artwork (+1/-0)
To merge this branch: bzr merge lp:~codygarver/elementaryos/seeds-add-notifyosd-theme
Reviewer Review Type Date Requested Status
Sergey "Shnatsel" Davidoff (community) Approve
Review via email: mp+161313@code.launchpad.net

This proposal supersedes a proposal from 2013-04-21.

Description of the change

Is this the right place for the theme or should it be in artwork?

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote : Posted in a previous version of this proposal

Also, how do you feel about the package name?

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote : Posted in a previous version of this proposal

I'd use "notify-osd-icons-elementary" package name because the original package is called "notify-osd-icons". I'd definitely put it in artwork where the rest of the icons is. I'd also add "Suggests: notify-osd-icons-elementary" to elementary-icon-theme package.

review: Abstain
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'artwork'
2--- artwork 2013-02-04 11:43:25 +0000
3+++ artwork 2013-04-28 07:32:26 +0000
4@@ -7,4 +7,5 @@
5 * elementary-icon-theme
6 * elementary-theme
7 * (elementary-wallpapers)
8+ * (notify-osd-icons-elementary)
9 * (plank-theme-pantheon)

Subscribers

People subscribed via source and target branches