Merge lp:~codygarver/elementaryos/fix-1291788 into lp:~elementary-os/elementaryos/default-settings-trusty

Proposed by Cody Garver
Status: Merged
Approved by: Cody Garver
Approved revision: 113
Merged at revision: 112
Proposed branch: lp:~codygarver/elementaryos/fix-1291788
Merge into: lp:~elementary-os/elementaryos/default-settings-trusty
Diff against target: 20 lines (+4/-1)
1 file modified
debian/elementary-default-settings.gsettings-override (+4/-1)
To merge this branch: bzr merge lp:~codygarver/elementaryos/fix-1291788
Reviewer Review Type Date Requested Status
RabbitBot Needs Information
Review via email: mp+219975@code.launchpad.net

Commit message

Set switch-input-source keys to value that does not conflict with <Super>space

To post a comment you must log in.
Revision history for this message
RabbitBot (rabbitbot-a) wrote :

Before we change these defaults to anything I'd like to see the rationale for the upstream change to Super+Space.
We used to have Alt+Shift and everyone was happy, but then THIS HAPPENED. I suggest we don't mess with it until we understand the reasoning behind the switch to Super+Space.

review: Needs Information
Revision history for this message
Cody Garver (codygarver) wrote :

It turns out that having them set to this crashes gnome-settings-daemon upon every login and you end up with not settings at all applied for anything. No theme, no media keys on keyboard, no nothing.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Okay well let's just set them to nothing for now and then we can have a new bug about them needing a shortcut and fix that in beta2

113. By Cody Garver

Set switch-input-source* keys to nothing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/elementary-default-settings.gsettings-override'
2--- debian/elementary-default-settings.gsettings-override 2014-04-23 02:37:25 +0000
3+++ debian/elementary-default-settings.gsettings-override 2014-06-08 17:01:49 +0000
4@@ -41,6 +41,9 @@
5 panel-run-dialog=[]
6 # Gala shows workspaces overview instead of desktop
7 show-desktop=['<Super>Down','<Super>s']
8+# See lp:1291788 for details about switch-input-source*
9+switch-input-source=['']
10+switch-input-source-backward=['']
11 switch-to-workspace-left=['<Super>Left']
12 switch-to-workspace-right=['<Super>Right']
13 switch-to-workspace-up=[]
14@@ -111,4 +114,4 @@
15 [org.pantheon.scratch.settings]
16 highlight-matching-brackets=true
17 show-line-numbers=true
18-style-scheme='solarizedlight'
19\ No newline at end of file
20+style-scheme='solarizedlight'

Subscribers

People subscribed via source and target branches