Merge lp:~codygarver/beat-box/remove-leftover-menuitems into lp:beat-box

Proposed by Cody Garver
Status: Merged
Approved by: Scott Ringwelski
Approved revision: 318
Merged at revision: 319
Proposed branch: lp:~codygarver/beat-box/remove-leftover-menuitems
Merge into: lp:beat-box
Diff against target: 68 lines (+0/-38)
1 file modified
src/LibraryWindow.vala (+0/-38)
To merge this branch: bzr merge lp:~codygarver/beat-box/remove-leftover-menuitems
Reviewer Review Type Date Requested Status
Scott Ringwelski Pending
Review via email: mp+80648@code.launchpad.net

Description of the change

Removes appmenu items that were moved to the about menu.

To post a comment you must log in.
Revision history for this message
Scott Ringwelski (sgringwe) wrote :

Does this follow the elementary design styles? Last I checked, the three items you are removing were supposed to be there.

Revision history for this message
Cody Garver (codygarver) wrote :

It does. Those items were moved to the About menu to make appmenus less cluttered. BeatBox is the last app that needs the changeover.

Revision history for this message
Scott Ringwelski (sgringwe) wrote :

Changes merged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/LibraryWindow.vala'
2--- src/LibraryWindow.vala 2011-10-28 03:01:14 +0000
3+++ src/LibraryWindow.vala 2011-10-28 05:17:29 +0000
4@@ -84,9 +84,6 @@
5 MenuItem fileSetMusicFolder;
6 MenuItem fileImportMusic;
7 MenuItem fileRescanMusicFolder;
8- ImageMenuItem helpOnline;
9- MenuItem helpTranslate;
10- MenuItem helpReport;
11 MenuItem editEqualizer;
12 ImageMenuItem editPreferences;
13
14@@ -253,9 +250,6 @@
15 fileSetMusicFolder = new MenuItem.with_label("Set Music Folder");
16 fileImportMusic = new MenuItem.with_label("Import to Library");
17 fileRescanMusicFolder = new MenuItem.with_label("Rescan Music Folder");
18- helpOnline = new ImageMenuItem.from_stock(Gtk.Stock.HELP, null);
19- helpTranslate = new MenuItem.with_label("Translate This Application...");
20- helpReport = new MenuItem.with_label("Report a Problem...");
21 editEqualizer = new MenuItem.with_label("Equalizer");
22 editPreferences = new ImageMenuItem.from_stock(Gtk.Stock.PREFERENCES, null);
23 settingsMenu = new Menu();
24@@ -311,10 +305,6 @@
25
26 settingsMenu.append(libraryOperations);
27 settingsMenu.append(new SeparatorMenuItem());
28- settingsMenu.append(helpOnline);
29- settingsMenu.append(helpTranslate);
30- settingsMenu.append(helpReport);
31- settingsMenu.append(new SeparatorMenuItem());
32 settingsMenu.append(editEqualizer);
33 settingsMenu.append(editPreferences);
34
35@@ -322,34 +312,6 @@
36 fileImportMusic.activate.connect(fileImportMusicClick);
37 fileRescanMusicFolder.activate.connect(fileRescanMusicFolderClick);
38
39- helpOnline.set_label("Get Help Online...");
40- helpOnline.activate.connect( () => {
41- string auth_uri = "https://answers.launchpad.net/beat-box";
42- try {
43- GLib.AppInfo.launch_default_for_uri (auth_uri, null);
44- }
45- catch(GLib.Error err) {
46- stdout.printf("Could not load webpage %s: %s\n", auth_uri, err.message);
47- }
48- });
49- helpTranslate.activate.connect( () => {
50- string auth_uri = "https://translations.launchpad.net/beat-box";
51- try {
52- GLib.AppInfo.launch_default_for_uri (auth_uri, null);
53- }
54- catch(GLib.Error err) {
55- stdout.printf("Could not load webpage %s: %s\n", auth_uri, err.message);
56- }
57- });
58- helpReport.activate.connect( () => {
59- string auth_uri = "https://bugs.launchpad.net/beat-box";
60- try {
61- GLib.AppInfo.launch_default_for_uri (auth_uri, null);
62- }
63- catch(GLib.Error err) {
64- stdout.printf("Could not load webpage %s: %s\n", auth_uri, err.message);
65- }
66- });
67
68 editPreferences.set_label("Preferences");
69

Subscribers

People subscribed via source and target branches