Merge lp:~codygarver/audience/filter-subtitle-files into lp:~audience-members/audience/trunk

Proposed by Cody Garver
Status: Merged
Merged at revision: 379
Proposed branch: lp:~codygarver/audience/filter-subtitle-files
Merge into: lp:~audience-members/audience/trunk
Diff against target: 33 lines (+16/-1)
1 file modified
src/Widgets/SettingsPopover.vala (+16/-1)
To merge this branch: bzr merge lp:~codygarver/audience/filter-subtitle-files
Reviewer Review Type Date Requested Status
Audience Members Pending
Review via email: mp+232594@code.launchpad.net

Commit message

Filter subtitle files in the External Subtitles file chooser

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/SettingsPopover.vala'
2--- src/Widgets/SettingsPopover.vala 2014-08-08 12:59:45 +0000
3+++ src/Widgets/SettingsPopover.vala 2014-08-28 16:36:56 +0000
4@@ -28,7 +28,22 @@
5
6 languages = new Gtk.ComboBoxText ();
7 subtitles = new Gtk.ComboBoxText ();
8+
9+ var all_files_filter = new Gtk.FileFilter ();
10+ all_files_filter.set_filter_name (_("All files"));
11+ all_files_filter.add_pattern ("*");
12+
13+ var subtitle_files_filter = new Gtk.FileFilter ();
14+ subtitle_files_filter.set_filter_name (_("Subtitle files"));
15+ subtitle_files_filter.add_mime_type ("application/smil"); // .smi
16+ subtitle_files_filter.add_mime_type ("application/x-subrip"); // .srt
17+ subtitle_files_filter.add_mime_type ("text/x-microdvd"); // .sub
18+ subtitle_files_filter.add_mime_type ("text/x-ssa"); // .ssa & .ass
19+ // exclude .asc, mimetype is generic "application/pgp-encrypted"
20+
21 external_subtitle_file = new Gtk.FileChooserButton (_("External Subtitles"), Gtk.FileChooserAction.OPEN);
22+ external_subtitle_file.add_filter (subtitle_files_filter);
23+ external_subtitle_file.add_filter (all_files_filter);
24
25 var lang_label = new Gtk.Label (_("Audio:"));
26 lang_label.halign = Gtk.Align.END;
27@@ -166,4 +181,4 @@
28
29 subtitles.active_id = current.to_string ();
30 }
31-}
32\ No newline at end of file
33+}

Subscribers

People subscribed via source and target branches

to all changes: