Merge lp:~cody-stevens/graphite/graphite into lp:graphite
Proposed by
Cody Stevens
Status: | Needs review |
---|---|
Proposed branch: | lp:~cody-stevens/graphite/graphite |
Merge into: | lp:graphite |
Diff against target: |
18 lines (+2/-2) 1 file modified
webapp/graphite/render/functions.py (+2/-2) |
To merge this branch: | bzr merge lp:~cody-stevens/graphite/graphite |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
graphite-dev | Pending | ||
Review via email: mp+132388@code.launchpad.net |
Description of the change
Graphite usually treats 'None' values as missing data which results in breaks in the lines of the graph. However, the sum and diff functions will basically treat them as a 0 value which can make the graph inaccurate when adding or diffing 2 series. This update checks to make sure that there are at least 2 values to be summed or diffed and if not will not do the diff/sum. This falls more in line with the way that graphite handles 'None' values IMHO.
To post a comment you must log in.
Unmerged revisions
- 865. By Cody Stevens
-
Updated safeDiff and safeSum to require 2 values to be summed/diffed.
Hi Cody,
Graphite's development has now moved to github (https:/ /github. com/graphite- project/ graphite- web), please submit your pull request there instead.