Code review comment for lp:~cody-somerville/launchpad/ppa-deletion

On Thursday 15 April 2010 06:20:42 you wrote:
> > Oh one more thing:
> >
> > lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py
> >
> > This needs changing so it ignores publish=False and status=DELETED
> > otherwise I expect it'll blow up when the directory gets removed.
>
> Why ignore archives that have publish=False?

Right, it should ignore archives that have disabled=True. Can you make that
change please :)

> Also, should I delete all subscriptions when we delete the archive or maybe
> update this script to do it? Or do you just want me to update it to ignore
> writing .htaccess file for deleted archives?

It just needs to ignore writing .htaccess, because the archiveroot won't be
there any more.

We can remove the subscriptions etc in a later branch when we do more of the
cleaning up.

Cheers.