Code review comment for lp:~cody-somerville/launchpad/ppa-deletion

Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :

> Oh one more thing:
>
> lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py
>
> This needs changing so it ignores publish=False and status=DELETED otherwise I
> expect it'll blow up when the directory gets removed.

Why ignore archives that have publish=False?

Also, should I delete all subscriptions when we delete the archive or maybe update this script to do it? Or do you just want me to update it to ignore writing .htaccess file for deleted archives?

« Back to merge proposal