HEXR

Merge ~codersquid/hexr/+git/submission-service-charm:invalid-status into ~hexr-dev/hexr/+git/submission-service-charm:master

  1. Git
  2. lp:~codersquid/hexr/+git/submission-service-charm
  3. invalid-status
  4. Merge into master
Proposed by Sheila Miguez
Status: Merged
Approved by: Sheila Miguez
Approved revision: e9ca1ebdf7f531ba7daddac385f9227f65271878
Merged at revision: e9ca1ebdf7f531ba7daddac385f9227f65271878
Proposed branch: ~codersquid/hexr/+git/submission-service-charm:invalid-status
Merge into: ~hexr-dev/hexr/+git/submission-service-charm:master
Diff against target: 13 lines (+1/-1)
1 file modified
reactive/submission_service.py (+1/-1)
Reviewer Review Type Date Requested Status
Sheila Miguez Approve
Review via email: mp+319863@code.launchpad.net

Commit message

change state to 'blocked' since 'error' is not a valid state

Description of the change

change state to 'blocked' since 'error' is not a valid state

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

hookenv doesn't allow error. minor change, self approving

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/submission_service.py b/reactive/submission_service.py
2index 2352ae2..fbf1d17 100644
3--- a/reactive/submission_service.py
4+++ b/reactive/submission_service.py
5@@ -204,7 +204,7 @@ def update_config():
6 database = get_database()
7 if not database:
8 log('cannot update config. database relation not found')
9- status_set('error', 'cannot update config. database relation not found.')
10+ status_set('blocked', 'cannot update config. database relation not found, but it should exist.')
11 return
12
13 # This renders a new settings file populated with up-to-date information

Subscribers

People subscribed via source and target branches

to all changes: