Merge ~codersquid/checkbox-ng:update-certification-url-again into checkbox-ng:master

Proposed by Sheila Miguez
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 8f5dc9f762f8380857ff7dfa9610b84f4d166b01
Merged at revision: 94f66af0becda44bfd28eb926047c214d43a8d9a
Proposed branch: ~codersquid/checkbox-ng:update-certification-url-again
Merge into: checkbox-ng:master
Diff against target: 30 lines (+4/-4)
1 file modified
checkbox_ng/launcher/subcommands.py (+4/-4)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Jonathan Cave Pending
Review via email: mp+331274@code.launchpad.net

Commit message

Correct the /api/v1/submission url.

Description of the change

Correct the /api/v1/submission url. It should use 'submission' not 'submissions'.

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

I've updated c3 to support either URL.

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_ng/launcher/subcommands.py b/checkbox_ng/launcher/subcommands.py
2index b938fb4..266ffb4 100644
3--- a/checkbox_ng/launcher/subcommands.py
4+++ b/checkbox_ng/launcher/subcommands.py
5@@ -94,10 +94,10 @@ class Submit(Command):
6 mode = 'rb'
7 options_string = "secure_id={0}".format(ctx.args.secure_id)
8 url = ('https://certification.canonical.com/'
9- 'api/v1/submissions/{}/'.format(ctx.args.secure_id))
10+ 'api/v1/submission/{}/'.format(ctx.args.secure_id))
11 if ctx.args.staging:
12 url = ('https://certification.staging.canonical.com/'
13- 'api/v1/submissions/{}/'.format(ctx.args.secure_id))
14+ 'api/v1/submission/{}/'.format(ctx.args.secure_id))
15 if ctx.args.submission.endswith('xml'):
16 from checkbox_ng.certification import CertificationTransport
17 transport_cls = CertificationTransport
18@@ -679,10 +679,10 @@ class Launcher(Command, MainLoopStage):
19 options = ""
20 if self.launcher.transports[transport].get('staging', False):
21 url = ('https://certification.staging.canonical.com/'
22- 'api/v1/submissions/{}/'.format(secure_id))
23+ 'api/v1/submission/{}/'.format(secure_id))
24 else:
25 url = ('https://certification.canonical.com/'
26- 'api/v1/submissions/{}/'.format(secure_id))
27+ 'api/v1/submission/{}/'.format(secure_id))
28 self.transports[transport] = cls(url, options)
29
30 def _export_results(self):

Subscribers

People subscribed via source and target branches