Code review comment for lp:galera

David Bennett (dbpercona) wrote :

Is this not the case for Boost and openssl? If so, perhaps the check build requirement should be changed to:

Check unit testing library and headers...

In any case, I had the library installed per the build requirements and the build failed without the check.h header being

On July 25, 2014 11:29:23 AM CDT, David Bennett <email address hidden> wrote:
>David Bennett has proposed merging lp:galera into
>lp:~dbennett455/galera/Bug1348714.
>
>Commit message:
>updated README to adding Check devel package as build requirement.
>
>Requested reviews:
> David Bennett (dbennett455)
>Related bugs:
> Bug #1078759 in Galera: "Excessive Memory usage"
> https://bugs.launchpad.net/galera/+bug/1078759
>Bug #1099478 in Galera: "setting gmcast.listen_addr manually does not
>allow nodes own address in gcomm address list"
> https://bugs.launchpad.net/galera/+bug/1099478
> Bug #1129512 in Galera: "Preferred SST Donors List"
> https://bugs.launchpad.net/galera/+bug/1129512
>Bug #1152565 in Galera: "Segfault in
>gcache::RingBuffer::get_new_buffer()"
> https://bugs.launchpad.net/galera/+bug/1152565
>Bug #1180792 in Galera: "wsrep_flow_control_sent/recv not a global
>counter?"
> https://bugs.launchpad.net/galera/+bug/1180792
> Bug #1199000 in Galera: "rpm packages asserting ownership of /usr/bin"
> https://bugs.launchpad.net/galera/+bug/1199000
> Bug #1201893 in Galera: "Make MacOSX and FreeBSD ports"
> https://bugs.launchpad.net/galera/+bug/1201893
> Bug #1215858 in Galera: "2.7 chores"
> https://bugs.launchpad.net/galera/+bug/1215858
> Bug #1217947 in Galera: "3.0beta chores"
> https://bugs.launchpad.net/galera/+bug/1217947
> Bug #1226300 in Galera: "GPLv3 file left over after relicense"
> https://bugs.launchpad.net/galera/+bug/1226300
> Bug #1229107 in Galera: "pc.checksum is enabled by default"
> https://bugs.launchpad.net/galera/+bug/1229107
>Bug #1232747 in Galera: "terminate called after throwing an instance of
>'std::out_of_range'"
> https://bugs.launchpad.net/galera/+bug/1232747
>Bug #1238226 in MySQL patches by Codership: "memcached plugin is
>missing in binary packages"
> https://bugs.launchpad.net/codership-mysql/+bug/1238226
> Bug #1240924 in Galera: "3.1 chores"
> https://bugs.launchpad.net/galera/+bug/1240924
> Bug #1243739 in Galera: "cppcheck issues"
> https://bugs.launchpad.net/galera/+bug/1243739
>Bug #1246128 in Galera: "Invalid write of size 8 | Address 0x1c23d1e8
>is 168 bytes inside a block of size 176 free'd | Galera 23.2.8"
> https://bugs.launchpad.net/galera/+bug/1246128
>Bug #1247402 in Galera: "pass write set flags to apply/commit
>callbacks"
> https://bugs.launchpad.net/galera/+bug/1247402
>Bug #1252461 in Galera: "Use gcached seqno information to better choose
>donor (to avoid SST)"
> https://bugs.launchpad.net/galera/+bug/1252461
> Bug #1254633 in Galera: "GPLv3 file left over after relicense"
> https://bugs.launchpad.net/galera/+bug/1254633
>Bug #1255964 in Galera: "Big transactions fail with: WSREP: Failed to
>open file '...'"
> https://bugs.launchpad.net/galera/+bug/1255964
> Bug #1259063 in Galera: "OpenSSL linking exceptions need to be added"
> https://bugs.launchpad.net/galera/+bug/1259063
>Bug #1259952 in Galera: "GCache file allocation may fail if file size
>is a multiple of page size"
> https://bugs.launchpad.net/galera/+bug/1259952
>Bug #1260193 in Galera: "XtraDB cluster doesn't check the parameters of
>wsrep_provider_options"
> https://bugs.launchpad.net/galera/+bug/1260193
> Bug #1261996 in Galera: "compilation on Solaris is broken"
> https://bugs.launchpad.net/galera/+bug/1261996
> Bug #1267507 in Galera: "cluster crashes on importing data"
> https://bugs.launchpad.net/galera/+bug/1267507
> Bug #1270921 in Galera: "maximum writeset size is not configurable"
> https://bugs.launchpad.net/galera/+bug/1270921
>Bug #1274199 in Galera: "Attempt to match against an empty key | Crash
>in UNIV_DEBUG"
> https://bugs.launchpad.net/galera/+bug/1274199
> Bug #1283100 in Galera: "garbd crashes on CentOS 6"
> https://bugs.launchpad.net/galera/+bug/1283100
>Bug #1284803 in Galera: "Joining node connects and crashed under load |
>Assertion `meta->gtid.seqno == wsrep_thd_trx_seqno(thd)' failed."
> https://bugs.launchpad.net/galera/+bug/1284803
> Bug #1286450 in Galera: "Boostrapping a Node in NON-PRIMARY Crashes"
> https://bugs.launchpad.net/galera/+bug/1286450
> Bug #1290006 in Galera: "SSL disabled without socket.ssl in Galera"
> https://bugs.launchpad.net/galera/+bug/1290006
> Bug #1290462 in Galera: "Build issues with clang"
> https://bugs.launchpad.net/galera/+bug/1290462
>Bug #1309507 in Galera: "Compile fails on FreeBSD ENOTREOVERABLE macro
>redefined"
> https://bugs.launchpad.net/galera/+bug/1309507
>Bug #1317674 in Galera: "build DEB package failed since mysql-5.5.37
>original source code removes Docs/mysql.info file"
> https://bugs.launchpad.net/galera/+bug/1317674
>
>For more details, see:
>https://code.launchpad.net/~codership/galera/3.x/+merge/228342
>
>updated README to adding Check devel package as build requirement.
>--
>https://code.launchpad.net/~codership/galera/3.x/+merge/228342
>You proposed lp:galera for merging.

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

« Back to merge proposal