Code review comment for lp:~codekaki/openerp-hr/7.0-hr_roster
Revision history for this message
| Chang Phui-Hock (phuihock) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
User is allowed to edit the duty roster in 'new' or 'draft' state, but must fill the whole month for the selected employee.
This is an acceptable behavior, at least for for my client.
I do not allow user to edit the duty roster once it has been approved. This is because once it has been approved by a Manager, the duty roster is used to generate final work days calendar.
This is also why I have workflow in this module. Though it doesn't really do anything, but it provides hooks for which other modules can inherit and extend to do something in each stage, say, send email notification, generate work days calendar etc.