Merge lp:~coalwater/lernid/fix-793805 into lp:lernid

Proposed by Mohammad AbuShady
Status: Merged
Approved by: John S. Gruber
Approved revision: 229
Merged at revision: 229
Proposed branch: lp:~coalwater/lernid/fix-793805
Merge into: lp:lernid
Diff against target: 26 lines (+9/-1)
1 file modified
lernid/widgets/Browser.py (+9/-1)
To merge this branch: bzr merge lp:~coalwater/lernid/fix-793805
Reviewer Review Type Date Requested Status
John S. Gruber Approve
Review via email: mp+70996@code.launchpad.net
To post a comment you must log in.
Revision history for this message
John S. Gruber (jsjgruber) wrote :

Looks very good and tests out fine. Thank you for your patch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lernid/widgets/Browser.py'
2--- lernid/widgets/Browser.py 2011-07-21 05:09:37 +0000
3+++ lernid/widgets/Browser.py 2011-08-10 06:58:26 +0000
4@@ -25,7 +25,7 @@
5
6 from lernid.widgets.Widget import Widget
7 from lernid.LernidOptions import Options
8-from lernid.lernidconfig import get_data_path
9+from lernid.lernidconfig import get_data_path, VERSION
10
11 class Browser(Widget):
12
13@@ -49,6 +49,14 @@
14 builder = self.builder_with_file('BrowserWidget.ui')
15 self.add(builder.get_object('browser_vbox'))
16 self._browser = webkit.WebView()
17+
18+ browser_settings=webkit.WebSettings()
19+ useragent=browser_settings.get_property('user-agent')
20+ parts=useragent.split(' ')
21+ parts[-1]='lernid/'+VERSION
22+ browser_settings.set_property('user-agent', ' '.join(parts))
23+ self._browser.set_settings(browser_settings)
24+
25 scroll = builder.get_object('browser_scroll')
26 scroll.add(self._browser)
27

Subscribers

People subscribed via source and target branches