Merge ~cnihelton/ubuntu/+source/wsl-pro-service:jammy-wsl-pro-service into ubuntu/+source/wsl-pro-service:ubuntu/noble-proposed

Proposed by Carlos Nihelton
Status: Needs review
Proposed branch: ~cnihelton/ubuntu/+source/wsl-pro-service:jammy-wsl-pro-service
Merge into: ubuntu/+source/wsl-pro-service:ubuntu/noble-proposed
Diff against target: 381 lines (+145/-6)
20 files modified
debian/changelog (+6/-0)
dev/null (+0/-6)
vendor/github.com/fsnotify/fsnotify/.gitignore (+10/-0)
vendor/github.com/fsnotify/fsnotify/.mailmap (+2/-0)
vendor/github.com/go-viper/mapstructure/v2/.gitignore (+6/-0)
vendor/github.com/pelletier/go-toml/v2/.gitattributes (+4/-0)
vendor/github.com/pelletier/go-toml/v2/.gitignore (+7/-0)
vendor/github.com/sagikazarmark/locafero/.gitignore (+8/-0)
vendor/github.com/sirupsen/logrus/.gitignore (+4/-0)
vendor/github.com/spf13/afero/.gitignore (+2/-0)
vendor/github.com/spf13/cast/.gitignore (+25/-0)
vendor/github.com/spf13/cobra/.gitignore (+39/-0)
vendor/github.com/spf13/cobra/.mailmap (+3/-0)
vendor/github.com/spf13/pflag/.gitignore (+2/-0)
vendor/github.com/spf13/viper/.gitignore (+8/-0)
vendor/github.com/subosito/gotenv/.gitignore (+4/-0)
vendor/go.uber.org/multierr/.gitignore (+4/-0)
vendor/golang.org/x/net/http2/.gitignore (+2/-0)
vendor/golang.org/x/sys/unix/.gitignore (+2/-0)
vendor/gopkg.in/ini.v1/.gitignore (+7/-0)
Reviewer Review Type Date Requested Status
Nick Rosbrook (community) Abstain
Vladimir Petko (community) Approve
git-ubuntu import Pending
Review via email: mp+495724@code.launchpad.net

This proposal supersedes a proposal from 2025-09-18.

Commit message

wsl-pro-service (0.1.18~22.04.1) jammy; urgency=medium

  * Backport version 0.1.18 to jammy (LP: #2107145):

Description of the change

Via this MP I'm requesting sponsorship to upload wsl-pro-service 0.1.18~22.04.1 to Jammy as a new package.

The reasoning for this has been discussed in the SRU bugs https://bugs.launchpad.net/ubuntu/+source/wsl-pro-service/+bug/2107145 and https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2091293. The gist is that we're attempting a one-shot rebuild of Jammy in the new tar-based format for WSL distros and taking advantage of that to enable support for Ubuntu Pro for WSL.

I'm basing this MP on noble-proposed because it makes it easier to review, there are no branches for Jammy at the moment, since this is a new package for that Ubuntu release.

The diff from noble-proposed is totally related to inert files, such as unused testdata or .gitignores that showed up in the vendored tree, recreated inside a Jammy instance to prevent surprises due slightly different toolchain versions. Source contents are otherwise the same, as they derive from the same upstream git tag and intended to build with the same version of Go (1.23).

Proof of builds for this patch can be found at the PPA links below:

- AMD64: https://launchpad.net/~ubuntu-wsl-dev/+archive/ubuntu/ppa/+build/31296118

- ARM64: https://launchpad.net/~ubuntu-wsl-dev/+archive/ubuntu/ppa/+build/31296119

To post a comment you must log in.
Revision history for this message
Vladimir Petko (vpa1977) wrote : Posted in a previous version of this proposal

Hi,

Would it be possible to base the backport on 0.18~24.04.3?

review: Needs Resubmitting
Revision history for this message
Carlos Nihelton (cnihelton) wrote (last edit ): Posted in a previous version of this proposal
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading wsl-pro-service_0.1.18~22.04.1.dsc: done.
  Uploading wsl-pro-service_0.1.18~22.04.1.tar.xz: done.
  Uploading wsl-pro-service_0.1.18~22.04.1_source.buildinfo: done.
  Uploading wsl-pro-service_0.1.18~22.04.1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Note. added LP bug reference on upload

Revision history for this message
Nick Rosbrook (enr0n) wrote :

Clearing from sponsors queue.

review: Abstain

Unmerged commits

6f9f3d1... by Carlos Nihelton <email address hidden>

Update the changelog

28cb464... by Carlos Nihelton <email address hidden>

Update vendor/ tree in Jammy

04ba106... by Carlos Nihelton <email address hidden>

Remove unused testdata

    Those files are no longer not even in unit tests
    They were replaced by contents inside the golden/ subfolder
    and should have been removed from Noble as well,
    though their existance causes no harm, as they don't participate
    in the test nor in the compilation of the binary output

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 2fc5b20..3466521 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+wsl-pro-service (0.1.18~22.04.1) jammy; urgency=medium
7+
8+ * Release wsl-pro-service 0.1.18 to jammy.
9+
10+ -- Carlos Nihelton <cnihelton@ubuntu.com> Fri, 07 Nov 2025 10:16:58 +0100
11+
12 wsl-pro-service (0.1.18~24.04.3) noble; urgency=medium
13
14 * Make debian/get-depends-go-bin-path.sh executable which is executed during
15diff --git a/internal/system/testdata/TestLandscapeEnable/do_not_append_wsl_tag_when_config_tag_is_provided/landscape.conf b/internal/system/testdata/TestLandscapeEnable/do_not_append_wsl_tag_when_config_tag_is_provided/landscape.conf
16deleted file mode 100644
17index be4dde4..0000000
18--- a/internal/system/testdata/TestLandscapeEnable/do_not_append_wsl_tag_when_config_tag_is_provided/landscape.conf
19+++ /dev/null
20@@ -1,6 +0,0 @@
21-[host]
22-url = www.example.com
23-
24-[client]
25-hello = world
26-tags = servers, oneiric, database, production
27diff --git a/internal/system/testdata/TestLandscapeEnable/do_not_append_wsl_tag_when_config_tag_is_provided_but_empty/landscape.conf b/internal/system/testdata/TestLandscapeEnable/do_not_append_wsl_tag_when_config_tag_is_provided_but_empty/landscape.conf
28deleted file mode 100644
29index 4f0500b..0000000
30--- a/internal/system/testdata/TestLandscapeEnable/do_not_append_wsl_tag_when_config_tag_is_provided_but_empty/landscape.conf
31+++ /dev/null
32@@ -1,6 +0,0 @@
33-[host]
34-url = www.example.com
35-
36-[client]
37-hello = world
38-tags =
39diff --git a/internal/system/testdata/TestLandscapeEnable/error_when_failing_to_override_the_ssl_certficate_path/landscape.conf b/internal/system/testdata/TestLandscapeEnable/error_when_failing_to_override_the_ssl_certficate_path/landscape.conf
40deleted file mode 100644
41index 75c264a..0000000
42--- a/internal/system/testdata/TestLandscapeEnable/error_when_failing_to_override_the_ssl_certficate_path/landscape.conf
43+++ /dev/null
44@@ -1,6 +0,0 @@
45-[host]
46-url = www.example.com
47-
48-[client]
49-hello = world
50-ssl_public_key = D:\Users\TestUser\certificate
51\ No newline at end of file
52diff --git a/internal/system/testdata/TestLandscapeEnable/error_when_the_config_file_cannot_be_written/landscape.conf b/internal/system/testdata/TestLandscapeEnable/error_when_the_config_file_cannot_be_written/landscape.conf
53deleted file mode 100644
54index c75b99e..0000000
55--- a/internal/system/testdata/TestLandscapeEnable/error_when_the_config_file_cannot_be_written/landscape.conf
56+++ /dev/null
57@@ -1,5 +0,0 @@
58-[host]
59-url = www.example.com
60-
61-[client]
62-hello = world
63\ No newline at end of file
64diff --git a/internal/system/testdata/TestLandscapeEnable/error_when_the_file_cannot_be_parsed/landscape.conf b/internal/system/testdata/TestLandscapeEnable/error_when_the_file_cannot_be_parsed/landscape.conf
65deleted file mode 100644
66index b600b3a..0000000
67--- a/internal/system/testdata/TestLandscapeEnable/error_when_the_file_cannot_be_parsed/landscape.conf
68+++ /dev/null
69@@ -1,3 +0,0 @@
70-{
71- "message": "Wait a second, this is not an ini file!"
72-}
73\ No newline at end of file
74diff --git a/internal/system/testdata/TestLandscapeEnable/error_when_the_landscape-config_command_fails/landscape.conf b/internal/system/testdata/TestLandscapeEnable/error_when_the_landscape-config_command_fails/landscape.conf
75deleted file mode 100644
76index c75b99e..0000000
77--- a/internal/system/testdata/TestLandscapeEnable/error_when_the_landscape-config_command_fails/landscape.conf
78+++ /dev/null
79@@ -1,5 +0,0 @@
80-[host]
81-url = www.example.com
82-
83-[client]
84-hello = world
85\ No newline at end of file
86diff --git a/internal/system/testdata/TestLandscapeEnable/error_when_the_landscape_user_does_not_exist/landscape.conf b/internal/system/testdata/TestLandscapeEnable/error_when_the_landscape_user_does_not_exist/landscape.conf
87deleted file mode 100644
88index c75b99e..0000000
89--- a/internal/system/testdata/TestLandscapeEnable/error_when_the_landscape_user_does_not_exist/landscape.conf
90+++ /dev/null
91@@ -1,5 +0,0 @@
92-[host]
93-url = www.example.com
94-
95-[client]
96-hello = world
97\ No newline at end of file
98diff --git a/internal/system/testdata/TestLandscapeEnable/success/landscape.conf b/internal/system/testdata/TestLandscapeEnable/success/landscape.conf
99deleted file mode 100644
100index c75b99e..0000000
101--- a/internal/system/testdata/TestLandscapeEnable/success/landscape.conf
102+++ /dev/null
103@@ -1,5 +0,0 @@
104-[host]
105-url = www.example.com
106-
107-[client]
108-hello = world
109\ No newline at end of file
110diff --git a/internal/system/testdata/TestLandscapeEnable/success_overriding_computer_title/landscape.conf b/internal/system/testdata/TestLandscapeEnable/success_overriding_computer_title/landscape.conf
111deleted file mode 100644
112index 94a5422..0000000
113--- a/internal/system/testdata/TestLandscapeEnable/success_overriding_computer_title/landscape.conf
114+++ /dev/null
115@@ -1,6 +0,0 @@
116-[host]
117-url = www.example.com
118-
119-[client]
120-computer_title = DEFAULT_COMPUTER_TITLE
121-hello = world
122diff --git a/internal/system/testdata/TestLandscapeEnable/success_overriding_the_ssl_certficate_path/landscape.conf b/internal/system/testdata/TestLandscapeEnable/success_overriding_the_ssl_certficate_path/landscape.conf
123deleted file mode 100644
124index 75c264a..0000000
125--- a/internal/system/testdata/TestLandscapeEnable/success_overriding_the_ssl_certficate_path/landscape.conf
126+++ /dev/null
127@@ -1,6 +0,0 @@
128-[host]
129-url = www.example.com
130-
131-[client]
132-hello = world
133-ssl_public_key = D:\Users\TestUser\certificate
134\ No newline at end of file
135diff --git a/vendor/github.com/fsnotify/fsnotify/.gitignore b/vendor/github.com/fsnotify/fsnotify/.gitignore
136new file mode 100644
137index 0000000..daea9dd
138--- /dev/null
139+++ b/vendor/github.com/fsnotify/fsnotify/.gitignore
140@@ -0,0 +1,10 @@
141+# go test -c output
142+*.test
143+*.test.exe
144+
145+# Output of go build ./cmd/fsnotify
146+/fsnotify
147+/fsnotify.exe
148+
149+/test/kqueue
150+/test/a.out
151diff --git a/vendor/github.com/fsnotify/fsnotify/.mailmap b/vendor/github.com/fsnotify/fsnotify/.mailmap
152new file mode 100644
153index 0000000..a04f290
154--- /dev/null
155+++ b/vendor/github.com/fsnotify/fsnotify/.mailmap
156@@ -0,0 +1,2 @@
157+Chris Howey <howeyc@gmail.com> <chris@howey.me>
158+Nathan Youngman <git@nathany.com> <4566+nathany@users.noreply.github.com>
159diff --git a/vendor/github.com/go-viper/mapstructure/v2/.gitignore b/vendor/github.com/go-viper/mapstructure/v2/.gitignore
160new file mode 100644
161index 0000000..470e7ca
162--- /dev/null
163+++ b/vendor/github.com/go-viper/mapstructure/v2/.gitignore
164@@ -0,0 +1,6 @@
165+/.devenv/
166+/.direnv/
167+/.pre-commit-config.yaml
168+/bin/
169+/build/
170+/var/
171diff --git a/vendor/github.com/pelletier/go-toml/v2/.gitattributes b/vendor/github.com/pelletier/go-toml/v2/.gitattributes
172new file mode 100644
173index 0000000..34a0a21
174--- /dev/null
175+++ b/vendor/github.com/pelletier/go-toml/v2/.gitattributes
176@@ -0,0 +1,4 @@
177+* text=auto
178+
179+benchmark/benchmark.toml text eol=lf
180+testdata/** text eol=lf
181diff --git a/vendor/github.com/pelletier/go-toml/v2/.gitignore b/vendor/github.com/pelletier/go-toml/v2/.gitignore
182new file mode 100644
183index 0000000..4b7c4ed
184--- /dev/null
185+++ b/vendor/github.com/pelletier/go-toml/v2/.gitignore
186@@ -0,0 +1,7 @@
187+test_program/test_program_bin
188+fuzz/
189+cmd/tomll/tomll
190+cmd/tomljson/tomljson
191+cmd/tomltestgen/tomltestgen
192+dist
193+tests/
194diff --git a/vendor/github.com/sagikazarmark/locafero/.gitignore b/vendor/github.com/sagikazarmark/locafero/.gitignore
195new file mode 100644
196index 0000000..8f07e60
197--- /dev/null
198+++ b/vendor/github.com/sagikazarmark/locafero/.gitignore
199@@ -0,0 +1,8 @@
200+/.devenv/
201+/.direnv/
202+/.task/
203+/bin/
204+/build/
205+/tmp/
206+/var/
207+/vendor/
208diff --git a/vendor/github.com/sirupsen/logrus/.gitignore b/vendor/github.com/sirupsen/logrus/.gitignore
209new file mode 100644
210index 0000000..1fb13ab
211--- /dev/null
212+++ b/vendor/github.com/sirupsen/logrus/.gitignore
213@@ -0,0 +1,4 @@
214+logrus
215+vendor
216+
217+.idea/
218diff --git a/vendor/github.com/spf13/afero/.gitignore b/vendor/github.com/spf13/afero/.gitignore
219new file mode 100644
220index 0000000..9c1d986
221--- /dev/null
222+++ b/vendor/github.com/spf13/afero/.gitignore
223@@ -0,0 +1,2 @@
224+sftpfs/file1
225+sftpfs/test/
226diff --git a/vendor/github.com/spf13/cast/.gitignore b/vendor/github.com/spf13/cast/.gitignore
227new file mode 100644
228index 0000000..53053a8
229--- /dev/null
230+++ b/vendor/github.com/spf13/cast/.gitignore
231@@ -0,0 +1,25 @@
232+# Compiled Object files, Static and Dynamic libs (Shared Objects)
233+*.o
234+*.a
235+*.so
236+
237+# Folders
238+_obj
239+_test
240+
241+# Architecture specific extensions/prefixes
242+*.[568vq]
243+[568vq].out
244+
245+*.cgo1.go
246+*.cgo2.c
247+_cgo_defun.c
248+_cgo_gotypes.go
249+_cgo_export.*
250+
251+_testmain.go
252+
253+*.exe
254+*.test
255+
256+*.bench
257diff --git a/vendor/github.com/spf13/cobra/.gitignore b/vendor/github.com/spf13/cobra/.gitignore
258new file mode 100644
259index 0000000..c7b459e
260--- /dev/null
261+++ b/vendor/github.com/spf13/cobra/.gitignore
262@@ -0,0 +1,39 @@
263+# Compiled Object files, Static and Dynamic libs (Shared Objects)
264+*.o
265+*.a
266+*.so
267+
268+# Folders
269+_obj
270+_test
271+
272+# Architecture specific extensions/prefixes
273+*.[568vq]
274+[568vq].out
275+
276+*.cgo1.go
277+*.cgo2.c
278+_cgo_defun.c
279+_cgo_gotypes.go
280+_cgo_export.*
281+
282+_testmain.go
283+
284+# Vim files https://github.com/github/gitignore/blob/master/Global/Vim.gitignore
285+# swap
286+[._]*.s[a-w][a-z]
287+[._]s[a-w][a-z]
288+# session
289+Session.vim
290+# temporary
291+.netrwhist
292+*~
293+# auto-generated tag files
294+tags
295+
296+*.exe
297+cobra.test
298+bin
299+
300+.idea/
301+*.iml
302diff --git a/vendor/github.com/spf13/cobra/.mailmap b/vendor/github.com/spf13/cobra/.mailmap
303new file mode 100644
304index 0000000..94ec530
305--- /dev/null
306+++ b/vendor/github.com/spf13/cobra/.mailmap
307@@ -0,0 +1,3 @@
308+Steve Francia <steve.francia@gmail.com>
309+Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
310+Fabiano Franz <ffranz@redhat.com> <contact@fabianofranz.com>
311diff --git a/vendor/github.com/spf13/pflag/.gitignore b/vendor/github.com/spf13/pflag/.gitignore
312new file mode 100644
313index 0000000..c3da290
314--- /dev/null
315+++ b/vendor/github.com/spf13/pflag/.gitignore
316@@ -0,0 +1,2 @@
317+.idea/*
318+
319diff --git a/vendor/github.com/spf13/viper/.gitignore b/vendor/github.com/spf13/viper/.gitignore
320new file mode 100644
321index 0000000..f1bbd42
322--- /dev/null
323+++ b/vendor/github.com/spf13/viper/.gitignore
324@@ -0,0 +1,8 @@
325+/.devenv/
326+/.direnv/
327+/.idea/
328+/.pre-commit-config.yaml
329+/bin/
330+/build/
331+/var/
332+/vendor/
333diff --git a/vendor/github.com/subosito/gotenv/.gitignore b/vendor/github.com/subosito/gotenv/.gitignore
334new file mode 100644
335index 0000000..7db37c1
336--- /dev/null
337+++ b/vendor/github.com/subosito/gotenv/.gitignore
338@@ -0,0 +1,4 @@
339+*.test
340+*.out
341+annotate.json
342+profile.cov
343diff --git a/vendor/go.uber.org/multierr/.gitignore b/vendor/go.uber.org/multierr/.gitignore
344new file mode 100644
345index 0000000..b9a05e3
346--- /dev/null
347+++ b/vendor/go.uber.org/multierr/.gitignore
348@@ -0,0 +1,4 @@
349+/vendor
350+cover.html
351+cover.out
352+/bin
353diff --git a/vendor/golang.org/x/net/http2/.gitignore b/vendor/golang.org/x/net/http2/.gitignore
354new file mode 100644
355index 0000000..190f122
356--- /dev/null
357+++ b/vendor/golang.org/x/net/http2/.gitignore
358@@ -0,0 +1,2 @@
359+*~
360+h2i/h2i
361diff --git a/vendor/golang.org/x/sys/unix/.gitignore b/vendor/golang.org/x/sys/unix/.gitignore
362new file mode 100644
363index 0000000..e3e0fc6
364--- /dev/null
365+++ b/vendor/golang.org/x/sys/unix/.gitignore
366@@ -0,0 +1,2 @@
367+_obj/
368+unix.test
369diff --git a/vendor/gopkg.in/ini.v1/.gitignore b/vendor/gopkg.in/ini.v1/.gitignore
370new file mode 100644
371index 0000000..588388b
372--- /dev/null
373+++ b/vendor/gopkg.in/ini.v1/.gitignore
374@@ -0,0 +1,7 @@
375+testdata/conf_out.ini
376+ini.sublime-project
377+ini.sublime-workspace
378+testdata/conf_reflect.ini
379+.idea
380+/.vscode
381+.DS_Store

Subscribers

People subscribed via source and target branches