Merge lp:~cmsa/openerp-fiscal-rules/openerp-fiscal-rules-product-account-tab-correction into lp:openerp-fiscal-rules

Proposed by Carlos Almeida
Status: Merged
Merge reported by: Raphaël Valyi - http://www.akretion.com
Merged at revision: not available
Proposed branch: lp:~cmsa/openerp-fiscal-rules/openerp-fiscal-rules-product-account-tab-correction
Merge into: lp:openerp-fiscal-rules
Diff against target: 18 lines (+5/-4)
1 file modified
account_product_fiscal_classification/product_view.xml (+5/-4)
To merge this branch: bzr merge lp:~cmsa/openerp-fiscal-rules/openerp-fiscal-rules-product-account-tab-correction
Reviewer Review Type Date Requested Status
Raphaël Valyi - http://www.akretion.com Approve
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+180707@code.launchpad.net

Description of the change

Corrected the view product_fiscal_classification_product_normal_form_view:
 It's the tab account in product view. Better reading, the fields got mixed in version 7.0.

To post a comment you must log in.
64. By Carlos Almeida

product account tab view correction, for better reading

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello, I tested and indeed it makes a better layout on v7. Thanks for the contrib!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_product_fiscal_classification/product_view.xml'
2--- account_product_fiscal_classification/product_view.xml 2013-02-11 23:55:25 +0000
3+++ account_product_fiscal_classification/product_view.xml 2013-08-17 21:22:07 +0000
4@@ -7,10 +7,11 @@
5 <field name="model">product.product</field>
6 <field name="inherit_id" ref="account.product_normal_form_view"/>
7 <field name="arch" type="xml">
8- <field name="property_account_expense" position="after">
9- <separator string="Fiscal Properties" colspan="4"/>
10- <field name="property_fiscal_classification" colspan="4" attrs="{'required': [('type', '!=', 'service')]}" select="2" on_change="fiscal_classification_id_change(property_fiscal_classification, taxes_id, supplier_taxes_id, context)"/>
11- </field>
12+ <group name="properties" position="before">
13+ <group string="Fiscal Properties" col="4" colspan="4">
14+ <field name="property_fiscal_classification" colspan="4" attrs="{'required': [('type', '!=', 'service')]}" select="2" on_change="fiscal_classification_id_change(property_fiscal_classification, taxes_id, supplier_taxes_id, context)"/>
15+ </group>
16+ </group>
17 </field>
18 </record>
19

Subscribers

People subscribed via source and target branches